You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/06 18:16:13 UTC
[GitHub] [skywalking-kong] dmsolr opened a new pull request #12: fix .rockspec issue and verify it in Makefile
dmsolr opened a new pull request #12:
URL: https://github.com/apache/skywalking-kong/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #12: fix .rockspec issue and verify it in Makefile
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-kong/pull/12#discussion_r627861127
##########
File path: Makefile
##########
@@ -17,14 +17,20 @@ SHELL := /bin/bash -o pipefail
VERSION ?= latest
RELEASE_SRC = skywalking-kong-${VERSION}-src
+ROCKSPEC = ./rockspec/kong-plugin-skywalking-${VERSION}-0.rockspec
Review comment:
I think this name is no longer available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng merged pull request #12: fix .rockspec issue and verify it in Makefile
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #12:
URL: https://github.com/apache/skywalking-kong/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on pull request #12: fix .rockspec issue and verify it in Makefile
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #12:
URL: https://github.com/apache/skywalking-kong/pull/12#issuecomment-833957499
Codes break, please recheck the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org