You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "woblerr (via GitHub)" <gi...@apache.org> on 2026/08/12 21:56:16 UTC
[PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
woblerr opened a new pull request, #1889:
URL: https://github.com/apache/cloudberry/pull/1889
Fixes [#1717](https://github.com/apache/cloudberry/issues/1717).
For forced activation of a stopped standby, start the postmaster directly with `GpStandbyStart` instead of using `promote_trigger_file` and `gpstart`. Then promote it with `pg_ctl promote`, wait for a successful utility `CHECKPOINT`, read the catalog, and restart the segments.
The existing 600-second `pg_ctl promote` timeout is preserved. A single monotonic deadline covers standby startup, promotion, and the utility `CHECKPOINT`, preventing these waits from accumulating while leaving segment restart to its existing timeout handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #1889:
URL: https://github.com/apache/cloudberry/pull/1889#discussion_r3826597670
##########
gpMgmt/test/behave/mgmt_utils/gpactivatestandby.feature:
##########
Review Comment:
I did a draft work in #1639, FYI. However, I don't have any more energy for it. If available, welcome to take over it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
Posted by "woblerr (via GitHub)" <gi...@apache.org>.
woblerr commented on code in PR #1889:
URL: https://github.com/apache/cloudberry/pull/1889#discussion_r3825525144
##########
gpMgmt/test/behave/mgmt_utils/gpactivatestandby.feature:
##########
Review Comment:
Hi! The gpMgmt Behave tests were previously part of the legacy Concourse pipeline, which was removed in https://github.com/apache/cloudberry/commit/a9cc25172248382669a670662799176798d9f259
Re-enabling them in the current CI would require reviewing and updating the existing tests, dependencies, and CI environment. I think this should be tracked in a separate issue, where we can discuss whether these tests should be added to the current CI and how. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
Posted by "leborchuk (via GitHub)" <gi...@apache.org>.
leborchuk commented on code in PR #1889:
URL: https://github.com/apache/cloudberry/pull/1889#discussion_r3828085495
##########
gpMgmt/test/behave/mgmt_utils/gpactivatestandby.feature:
##########
Review Comment:
> I did a draft work in #1639, FYI. However, I don't have any more energy for it. If available, welcome to take over it.
There could be a chance that failed tests just shows us there are real issue in our code.
And the CI is great, we just should fix bugs in our repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
Posted by "leborchuk (via GitHub)" <gi...@apache.org>.
leborchuk commented on code in PR #1889:
URL: https://github.com/apache/cloudberry/pull/1889#discussion_r3802349106
##########
gpMgmt/test/behave/mgmt_utils/gpactivatestandby.feature:
##########
Review Comment:
Hi! Great! By the way, do not want to add run beehave tests in CI? I think we do not launch them, but have fixes in python environment. It will be great to check if everything is Ok here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix gpactivatestandby after clean shutdown. [cloudberry]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop merged PR #1889:
URL: https://github.com/apache/cloudberry/pull/1889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org