You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/19 13:20:20 UTC
[GitHub] [cordova-plugin-inappbrowser] mosabab opened a new pull request
#648: [android] Correcting the information regarding lefttoright option
mosabab opened a new pull request #648: [android] Correcting the information regarding lefttoright option
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/648
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
The current documentation for __lefttoright__ option was wrong:
__lefttoright__: Set to `yes` to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the left and close button to the right.
The right and corrected information that should used in documentation is:
__lefttoright__: Set to `yes` to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the right and close button to the left. Default value is `no`.
### Description
<!-- Describe your changes in detail -->
The current information in the documentation about __lefttoright__ option was wrote in wrong information as comparing it to the real situation for the current settings.
### Testing
<!-- Please describe in detail how you tested your changes. -->
You can test it in any android devices using any versions.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #648:
[android] Correcting the documentation regarding lefttoright option
information
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #648: [android] Correcting the documentation regarding lefttoright option information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/648#issuecomment-603779449
Yes, I'll try to check this today. Could you provide some screenshots with the lefttoright option set to yes and no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #648:
[android] Correcting the documentation regarding lefttoright option
information
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #648: [android] Correcting the documentation regarding lefttoright option information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/648#issuecomment-603832026
> Yes, I'll try to check this today. Could you provide some screenshots with the lefttoright option set to yes and no?
There is no needs for screenshots, you can test it from your side and see the results.
`README.md` file documentation for this option `lefttoright` was written in wrong information.
As current documentation for this plugin (wrong information):
`lefttoright`: Set to `yes` to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the left and close button to the right.
******* BUT *******
If you set `yes` you will see the opposite situation in real testing. (navigation buttons go to the right and close button to the left).
So, I created this pull just to correct the information regarding this option `lefttoright` for Android.
This pull is to swap information regarding this option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 merged pull request #648:
[android] Correcting the documentation regarding lefttoright option
information
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #648: [android] Correcting the documentation regarding lefttoright option information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #648:
[android] Correcting the documentation regarding lefttoright option
information
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #648: [android] Correcting the documentation regarding lefttoright option information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/648#issuecomment-602729543
@timbru31 could you please check this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org