You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/15 04:00:14 UTC

[GitHub] [skywalking] codecov[bot] commented on pull request #5845: remove unused min date timebucket in jdbc delethistory logical.

codecov[bot] commented on pull request #5845:
URL: https://github.com/apache/skywalking/pull/5845#issuecomment-727426491


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=h1) Report
   > Merging [#5845](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=desc) (5bcae70) into [master](https://codecov.io/gh/apache/skywalking/commit/edf0bce37f682c093d1ea5bcca0a6d2d1ecc2cc4?el=desc) (edf0bce) will **decrease** coverage by `15.87%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5845/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5845       +/-   ##
   =============================================
   - Coverage     51.30%   35.43%   -15.88%     
   + Complexity     3468     2005     -1463     
   =============================================
     Files          1653      737      -916     
     Lines         35385    18518    -16867     
     Branches       3852     1712     -2140     
   =============================================
   - Hits          18155     6561    -11594     
   + Misses        16331    11462     -4869     
   + Partials        899      495      -404     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-72.00%)` | `0.00 <0.00> (-6.00)` | |
   | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
   | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (+3.17%)` | `1.00 <0.00> (ø)` | |
   | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/5845/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=footer). Last update [edf0bce...5bcae70](https://codecov.io/gh/apache/skywalking/pull/5845?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org