[jira] [Commented] (DERBY-5887) Garbage printed for error LOG_UNDO_FAILED

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434072#comment-13434072 ] 

Knut Anders Hatlen commented on DERBY-5887:
-------------------------------------------

I think the usages of SQLState.LOG_UNDO_FAILED in FileLogger are actually OK. They use this variant of newException():

	public static StandardException newException(String messageID, Throwable t, Object a1, Object a2, Object a3) {
		Object[] oa = new Object[] {a1, a2, a3};
		return new StandardException(messageID, t, oa);
	}

Note that this method ends up passing only three of the arguments to the message formatter. The exception argument will be linked to the returned StandardException.
                
> Garbage printed for error LOG_UNDO_FAILED
> -----------------------------------------
>
>                 Key: DERBY-5887
>                 URL: https://issues.apache.org/jira/browse/DERBY-5887
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.10.0.0
>            Reporter: Rick Hillegas
>
> SQLState.LOG_UNDO_FAILED maps to a message which has 3 arguments, the first of which is a transaction id. However, when this SQLState is raised by FileLogger, it is handed 4 arguments, the first of which is an exception. This will result in a confusing garbage message for the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira