You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/31 05:21:22 UTC
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request
#5013: add start-index and stop-index property in literal-expression for
PR#5006
strongduanmu opened a new pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013
Fixes #4995 .
Changes proposed in this pull request:
- add start-index and stop-index property in literal-expression for PR#5006
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #5013: add start-index and stop-index property in
literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#discussion_r400669061
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml
##########
@@ -404,8 +404,8 @@
<column-left-value name="user_id" start-index="64" stop-index="70" literal-start-index="64" literal-stop-index="70" />
<operator type="=" />
<compare-right-value>
- <parameter-marker-expression value="2" start-index="74" stop-index="74" />
Review comment:
Hi Please keep this blank space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5013:
add start-index and stop-index property in literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #5013: add
start-index and stop-index property in literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#issuecomment-606451384
/ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on a change in
pull request #5013: add start-index and stop-index property in
literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#discussion_r400672441
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml
##########
@@ -386,8 +386,8 @@
<assignment start-index="19" stop-index="28" literal-stop-index="28">
<column name="status" start-index="19" stop-index="24" />
<assignment-value>
- <parameter-marker-expression value="0" start-index="28" stop-index="28" />
Review comment:
> Hi Please keep this blank space.
Ok, I'll modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5013: add
start-index and stop-index property in literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#issuecomment-606534969
Appreciated your carefulness. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5013: add
start-index and stop-index property in literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#issuecomment-606412424
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=h1) Report
> Merging [#5013](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/026ef43e98dc7cd4481be69f4e80962fb3499a96&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `16.24%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5013 +/- ##
============================================
+ Coverage 53.82% 53.84% +0.01%
- Complexity 441 443 +2
============================================
Files 1139 1140 +1
Lines 20474 20472 -2
Branches 3741 3741
============================================
+ Hits 11021 11024 +3
+ Misses 8748 8744 -4
+ Partials 705 704 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ncrypt/metadata/EncryptTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFRhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/encrypt/merge/EncryptResultDecoratorEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9FbmNyeXB0UmVzdWx0RGVjb3JhdG9yRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ite/context/EncryptSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29udGV4dC9FbmNyeXB0U1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `80.00% <0.00%> (-8.89%)` | `0.00 <0.00> (ø)` | |
| [...enerator/impl/EncryptProjectionTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByb2plY3Rpb25Ub2tlbkdlbmVyYXRvci5qYXZh) | `82.50% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...rslave/route/engine/MasterSlaveRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-bWFzdGVyLXNsYXZlLWNvcmUvbWFzdGVyLXNsYXZlLWNvcmUtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3JvdXRlL2VuZ2luZS9NYXN0ZXJTbGF2ZVJvdXRlRGVjb3JhdG9yLmphdmE=) | `89.47% <0.00%> (-4.98%)` | `0.00 <0.00> (ø)` | |
| [...rite/context/ShadowSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvY29udGV4dC9TaGFkb3dTUUxSZXdyaXRlQ29udGV4dERlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/sharding/merge/ShardingResultMergerEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9TaGFyZGluZ1Jlc3VsdE1lcmdlckVuZ2luZS5qYXZh) | `75.00% <0.00%> (-10.72%)` | `0.00 <0.00> (ø)` | |
| ... and [49 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=footer). Last update [a194fec...3fc75f4](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on a change in
pull request #5013: add start-index and stop-index property in
literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#discussion_r400672650
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml
##########
@@ -404,8 +404,8 @@
<column-left-value name="user_id" start-index="64" stop-index="70" literal-start-index="64" literal-stop-index="70" />
<operator type="=" />
<compare-right-value>
- <parameter-marker-expression value="2" start-index="74" stop-index="74" />
Review comment:
> Hi Please keep this blank space.
Ok, I'll modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #5013: add start-index and stop-index property in
literal-expression for PR#5006
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
URL: https://github.com/apache/incubator-shardingsphere/pull/5013#discussion_r400668981
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml
##########
@@ -386,8 +386,8 @@
<assignment start-index="19" stop-index="28" literal-stop-index="28">
<column name="status" start-index="19" stop-index="24" />
<assignment-value>
- <parameter-marker-expression value="0" start-index="28" stop-index="28" />
Review comment:
Hi Please keep this blank space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services