You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2024/02/07 06:46:57 UTC
[PR] use NullFilter for SQL rewrite of MV_CONTAINS and MV_OVERLAP for null array elements (druid)
clintropolis opened a new pull request, #15855:
URL: https://github.com/apache/druid/pull/15855
### Description
Fixes an oversight after #14542 that happens in the SQL planner rewrite of `MV_CONTAINS` and `MV_OVERLAP` when faced with array elements that are `NULL`, where we were incorrectly using `EqualityFilter` instead of `NullFilter` for null elements (`EqualityFilter` does not accept null elements).
Without the changes of this PR, the added tests would fail with errors like:
```
org.apache.druid.error.DruidException: Invalid equality filter on column [dim3], matchValue cannot be null
```
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] use NullFilter for SQL rewrite of MV_CONTAINS and MV_OVERLAP for null array elements (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #15855:
URL: https://github.com/apache/druid/pull/15855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org