You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2012/03/13 17:32:42 UTC
[jira] [Created] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Configuration deprecation logic breaks backwards compatibility
--------------------------------------------------------------
Key: HADOOP-8167
URL: https://issues.apache.org/jira/browse/HADOOP-8167
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.24.0, 0.23.3
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Priority: Blocker
Fix For: 0.23.3
The deprecated Configuration logic works as follows:
For a dK deprecated key in favor of nK:
* on set(dK, V), it stores (nK,V)
* on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230127#comment-13230127 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #198 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/198/])
Merge -r 1300641:1300642 from trunk to branch. FIXES: HADOOP-8167 (Revision 1300644)
Result = UNSTABLE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300644
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228726#comment-13228726 ]
Alejandro Abdelnur commented on HADOOP-8167:
--------------------------------------------
The failed test 'TestViewFS' seems unrelated
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229436#comment-13229436 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1882 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1882/])
HADOOP-8167. Configuration deprecation logic breaks backwards compatibility (tucu) (Revision 1300642)
Result = ABORTED
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300642
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Attachment: HADOOP-8167.patch
Going for option #2, seems the least invasive one. taking care of unset as well. added testcases
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230149#comment-13230149 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #226 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/226/])
Merge -r 1300641:1300642 from trunk to branch. FIXES: HADOOP-8167 (Revision 1300644)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300644
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242685#comment-13242685 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8167:
------------------------------------------------
Hi Alejandro, the patch seems causing some problems. Could you take a look HADOOP-8172?
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229434#comment-13229434 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #687 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/687/])
Merge -r 1300641:1300642 from trunk to branch. FIXES: HADOOP-8167 (Revision 1300644)
Result = ABORTED
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300644
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Status: Patch Available (was: Open)
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228684#comment-13228684 ]
Alejandro Abdelnur commented on HADOOP-8167:
--------------------------------------------
Forgot to mention, this is breaking Oozie with Hadoop 0.23 as Oozie heavily uses Configuration objects with iterators
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230174#comment-13230174 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1020 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1020/])
HADOOP-8167. Configuration deprecation logic breaks backwards compatibility (tucu) (Revision 1300642)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300642
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8167:
----------------------------------------
Fix Version/s: 0.23.3
Pulled this into branch-0.23
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3, 2.0.0-alpha
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Status: Patch Available (was: Open)
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230118#comment-13230118 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #985 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/985/])
HADOOP-8167. Configuration deprecation logic breaks backwards compatibility (tucu) (Revision 1300642)
Result = UNSTABLE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300642
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228698#comment-13228698 ]
Hadoop QA commented on HADOOP-8167:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518212/HADOOP-8167.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/706//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/706//console
This message is automatically generated.
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228888#comment-13228888 ]
Hadoop QA commented on HADOOP-8167:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518212/HADOOP-8167.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/708//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/708//console
This message is automatically generated.
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229370#comment-13229370 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1948 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1948/])
HADOOP-8167. Configuration deprecation logic breaks backwards compatibility (tucu) (Revision 1300642)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300642
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229312#comment-13229312 ]
Tom White commented on HADOOP-8167:
-----------------------------------
#2 seems like the best option in this case. +1 for the patch.
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229374#comment-13229374 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #679 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/679/])
Merge -r 1300641:1300642 from trunk to branch. FIXES: HADOOP-8167 (Revision 1300644)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300644
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228784#comment-13228784 ]
Alejandro Abdelnur commented on HADOOP-8167:
--------------------------------------------
verified with oozie and works like in MR1
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229394#comment-13229394 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #670 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/670/])
Merge -r 1300641:1300642 from trunk to branch. FIXES: HADOOP-8167 (Revision 1300644)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300644
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Attachment: (was: HADOOP-8167.patch)
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Attachment: HADOOP-8167.patch
this time with --no-prefix
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228511#comment-13228511 ]
Alejandro Abdelnur commented on HADOOP-8167:
--------------------------------------------
Options that I see to address this:
1* set(dK, V) should store (dK, V) and get(nK) should do a reverse look up if nK is not found
ISSUE: This may break new code that iterates and expects nK in the iterator.
2* set(dK, V) & set(nK, V) should store both (dK, V) and (nK, V)
ISSUE: increases the number of stored key/values.
3* keep current set/get logic and make iterator() to return 'duplicated' entries for deprecated values (dK, V) & (nK, V)
ISSUE: complexity in the iterator logic as well.
4* keep track in Configuration of the key used regardless of being deprecated or not and return those on iterators()
ISSUE: it will require Configuration to have an additional data structure to keep track of deprecate values being used. This will add more complexity to the configuration.
I'm inclined to do either #2 or #3.
Thoughts?
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229396#comment-13229396 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1873 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1873/])
HADOOP-8167. Configuration deprecation logic breaks backwards compatibility (tucu) (Revision 1300642)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1300642
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Status: Open (was: Patch Available)
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425716#comment-13425716 ]
Hudson commented on HADOOP-8167:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #330 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/])
svn merge -c 1301551,1300642,1332821,1303884 FIXES:MAPREDUCE-4010,HADOOP-8167,HADOOP-8172,HADOOP-8197 Patches to fix OOZIE-761 (Revision 1367102)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367102
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestWritableJobConf.java
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3, 2.0.0-alpha
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8167) Configuration deprecation logic
breaks backwards compatibility
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8167:
---------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk and branch-0.23
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
> Key: HADOOP-8167
> URL: https://issues.apache.org/jira/browse/HADOOP-8167
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 0.23.3
>
> Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration to find (dK, V).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira