You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/19 19:43:52 UTC
[GitHub] [superset] ktmud opened a new issue #18096: [Dashboard Editor] Cmd + Z should not revert layout changes when editing chart title
ktmud opened a new issue #18096:
URL: https://github.com/apache/superset/issues/18096
#### How to reproduce the bug
1. Go to dashboard edit mode
2. Make some layout changes. For example, resize a chart.
3. Click on a chart title to edit it:
<img width="420" alt="Xnip2022-01-19_11-40-07" src="https://user-images.githubusercontent.com/335541/150202161-a1364779-9442-40b1-8470-1b45fa034a30.png">
4. Enter something and click on Ctr + Z (Windows) or Cmd + Z (macOS)
### Expected results
The input value revert to previous edits. The layout doesn't change.
### Actual results
The layout change was reverted but the input value didn't change.
#### Screenshots
N/A
### Environment
Latest `master` branch
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ edited a comment on issue #18096: [Dashboard Editor] Cmd + Z should not revert layout changes when editing chart title
Posted by GitBox <gi...@apache.org>.
stephenLYZ edited a comment on issue #18096:
URL: https://github.com/apache/superset/issues/18096#issuecomment-1019299968
Agree. I think it makes sense. And I open this https://github.com/apache/superset/pull/18137 to improve this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on issue #18096: [Dashboard Editor] Cmd + Z should not revert layout changes when editing chart title
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on issue #18096:
URL: https://github.com/apache/superset/issues/18096#issuecomment-1019299968
Agree. I think it makes sense. And I open a https://github.com/apache/superset/pull/18137 to improve this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org