[GitHub] [tvm] StrongerXi commented on pull request #13311: [BugFix][Driver] Correctly propogate simple-mode flag in LowerSchedule

[GitBox <gi...@apache.org>]

StrongerXi commented on PR #13311:
URL: https://github.com/apache/tvm/pull/13311#issuecomment-1306056395

   > Thanks for sending this! Would it be possible that we can add some tests with simple_mode set to true/false? Otherwise LGTM.
   
   Thanks. I did look into existing tests for `LowerSchedule` or `tvm.lower`, unfortunately none of them really tests `simple_mode`, which seems to be a convenience flag for debugging/testing purposes.
   
   I could write a simple `tvm.lower(..., simple_mode=...)` unittest, but it actually doesn't go through this problematic version of `LowerSchedule`, which is only used [here](https://github.com/apache/tvm/blob/main/src/relay/backend/te_compiler.cc#L447-L448) and [here](https://github.com/apache/tvm/blob/main/src/relay/backend/te_compiler_cache.cc#L852-L853), and they don't even use the `simple_mode` flag.
   
   I feel like the testing effort here isn't well worth it, but let me know what you think:).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org