[GitHub] [solr] danrosher commented on a diff in pull request #935: SOLR-16286 : Topic stream not honoring initialCheckpoint in getPersis…

[GitBox <gi...@apache.org>]

danrosher commented on code in PR #935:
URL: https://github.com/apache/solr/pull/935#discussion_r925427240


##########
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/StreamDecoratorTest.java:
##########
@@ -3048,7 +3048,7 @@ public void testPriorityStream() throws Exception {
       expression =
           StreamExpressionParser.parse(
               "priority(topic(collection1, collection1, q=\"a_s:hello\", fl=\"id,a_i\", id=1000000, initialCheckpoint=0),"

Review Comment:
   I wasn't sure whether to remove initialCheckpoint=0, or alter the test expected results which is what I did. Shall I remove the initialCheckpoint=0?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org