[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6663: Minor: Add more doc strings to WindowExpr

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6663:
URL: https://github.com/apache/arrow-datafusion/pull/6663#discussion_r1229689806


##########
datafusion/physical-expr/src/window/built_in_window_function_expr.rs:
##########
@@ -95,10 +95,13 @@ pub trait BuiltInWindowFunctionExpr: Send + Sync + std::fmt::Debug {
         false
     }
 
-    /// Does the window function use the values from its window frame?
+    /// Does the window function use the values from the window frame,
+    /// if one is specified?
     ///
     /// If this function returns true, [`Self::create_evaluator`] must
-    /// implement [`PartitionEvaluator::evaluate_inside_range`]
+    /// implement [`PartitionEvaluator::evaluate_inside_range`]. See
+    /// details and examples on [`PartitionEvaluator::evaluate`].
+

Review Comment:
   ```suggestion
   ```
   redundant line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org