[GitHub] carlosrovira closed pull request #304: NumericStepper - enter value into textinput should dispatch ValueChangeEvent

[GitBox <gi...@apache.org>]

carlosrovira closed pull request #304: NumericStepper -  enter value into textinput should dispatch ValueChangeEvent
URL: https://github.com/apache/royale-asjs/pull/304
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
index 76f640c53..a2ab34f0e 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
@@ -184,7 +184,12 @@ package org.apache.royale.jewel.beads.views
 			var newValue:Number = Number(input.text);
 
 			if( !isNaN(newValue) ) {
+				var oldValue:Number = spinner.value;
 				spinner.value = newValue;
+				if (oldValue != spinner.value) {
+					var newEvent:ValueChangeEvent = ValueChangeEvent.createUpdateEvent(_strand, "value", oldValue, spinner.value);
+					IEventDispatcher(_strand).dispatchEvent(newEvent);
+				}
 			}
 			else {
 				input.text = String(spinner.value);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services