[jira] Commented: (HADOOP-4854) Capacity Scheduler should read the reclaim-capacity-interval config value from its own config file

["Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655949#action_12655949 ] 

Sreekanth Ramakrishnan commented on HADOOP-4854:
------------------------------------------------

Attachign output of ant test-patch which I ran on the local box.

{noformat}
     [exec] 
     [exec] 
     [exec] 
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec] 
{noformat}

> Capacity Scheduler should read the reclaim-capacity-interval config value from its own config file
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4854
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>            Reporter: Vivek Ratan
>            Assignee: Sreekanth Ramakrishnan
>            Priority: Minor
>         Attachments: HADOOP-4854-1.patch
>
>
> The Capacity Scheduler needs to know the time interval for checking whether capacity needs to be reclaimed. This is represented by the static variable RECLAIM_CAPACITY_INTERVAL. This value is currently read as follows: 
> {code}
>     RECLAIM_CAPACITY_INTERVAL = conf.getLong("mapred.capacity-scheduler.reclaimCapacity.interval", 5);
> {code}
> This is incorrect for the following reasons: 
> * ""mapred.capacity-scheduler.reclaimCapacity.interval" is not present in any of the config files: hadoop-site.xml or capacity-scheduler.xml.
> * "mapred.capacity-scheduler.reclaimCapacity.interval" should be specified in the scheduler's config file, capacity-scheduler.xml. It should be read through org.apache.hadoop.mapred.CapacitySchedulerConf. 
> * The Forrest documentation for the Capacity Scheduler should describe this setting. We should probably create a new sub-section under 'Configuration', titled 'Configuring properties for the Scheduler'. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.