[GitHub] [spark] wangyum commented on a change in pull request #24294: [SPARK-27383][SQL][TEST] Avoid using hard-coded jar names in Hive tests

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #24294: [SPARK-27383][SQL][TEST] Avoid using hard-coded jar names in Hive tests
URL: https://github.com/apache/spark/pull/24294#discussion_r272019847
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
 ##########
 @@ -116,6 +116,9 @@ class TestHiveContext(
     @transient override val sparkSession: TestHiveSparkSession)
   extends SQLContext(sparkSession) {
 
+  val HIVE_CONTRIB_JAR: String = "hive-contrib-0.13.1.jar"
+  val HIVE_HCATALOG_CORE_JAR: String = "hive-hcatalog-core-0.13.1.jar"
+
 
 Review comment:
   When we upgraded built-in Hive to 2.3.4:
   ```scala
   val HIVE_CONTRIB_JAR = if (HiveUtils.isHive23) "hive-contrib-2.3.4.jar" else "hive-contrib-0.13.1.jar"
   val HIVE_HCATALOG_CORE_JAR = if (HiveUtils.isHive23) "hive-hcatalog-core-2.3.4.jar" else "hive-hcatalog-core-0.13.1.jar"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org