You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/01/06 00:31:28 UTC
[GitHub] [cassandra] jonmeredith opened a new pull request #1377: CASSANDRA-17239 for cassandra-3.0
jonmeredith opened a new pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377
See [CASSANDRA-17239](https://issues.apache.org/jira/browse/CASSANDRA-17239)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #1377: CASSANDRA-17239 for cassandra-3.0
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1377: CASSANDRA-17239 for cassandra-3.0
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on a change in pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377#discussion_r779775822
##########
File path: test/unit/org/apache/cassandra/db/compaction/CompactionExecutorTest.java
##########
@@ -63,44 +70,43 @@ public void destroy() throws Exception
executor.awaitTermination(1, TimeUnit.MINUTES);
}
+ void awaitExecution() throws Exception
+ {
+ assert afterExecuteCompleted.await(10, TimeUnit.SECONDS) : "afterExecute failed to complete";
Review comment:
You're absolutely right. I was thinking it was sleeping 10 seconds and that's why you moved to a 10 second timeout on the signal wait; totally spaced that sleep's ms. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1377: CASSANDRA-17239 for cassandra-3.0
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on a change in pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377#discussion_r779638346
##########
File path: test/unit/org/apache/cassandra/db/compaction/CompactionExecutorTest.java
##########
@@ -63,44 +70,43 @@ public void destroy() throws Exception
executor.awaitTermination(1, TimeUnit.MINUTES);
}
+ void awaitExecution() throws Exception
+ {
+ assert afterExecuteCompleted.await(10, TimeUnit.SECONDS) : "afterExecute failed to complete";
Review comment:
You inherited this from the initial implementation, but is there a reason we're only allowing for 10 seconds to execute before timing out? This seems like the kind of thing that could flake in adverse environments / scheduling / k8s silliness in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jonmeredith commented on a change in pull request #1377: CASSANDRA-17239 for cassandra-3.0
Posted by GitBox <gi...@apache.org>.
jonmeredith commented on a change in pull request #1377:
URL: https://github.com/apache/cassandra/pull/1377#discussion_r779738259
##########
File path: test/unit/org/apache/cassandra/db/compaction/CompactionExecutorTest.java
##########
@@ -63,44 +70,43 @@ public void destroy() throws Exception
executor.awaitTermination(1, TimeUnit.MINUTES);
}
+ void awaitExecution() throws Exception
+ {
+ assert afterExecuteCompleted.await(10, TimeUnit.SECONDS) : "afterExecute failed to complete";
Review comment:
Happy to bump it up to a minute - the original test doesn't have a timeout as far as I can tell - it's just sleeping 10 milliseconds between checks on the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org