[GitHub] [flink] twalthr commented on a change in pull request #11568: [FLINK-16779][table] Add RAW type support in DDL and functions

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #11568: [FLINK-16779][table] Add RAW type support in DDL and functions
URL: https://github.com/apache/flink/pull/11568#discussion_r404205000
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
 ##########
 @@ -484,6 +493,9 @@ object FlinkTypeFactory {
       // CURSOR for UDTF case, whose type info will never be used, just a placeholder
       case CURSOR => new TypeInformationRawType[Nothing](new NothingTypeInfo)
 
+      case null if relDataType.isInstanceOf[RawRelDataType] =>
 
 Review comment:
   This was actually a conscious decision. `SqlTypeName` is used (as the name suggests) for SQL types. All additional types don't need a type name. The usage of `SqlTypeName.ANY` in the past was actually a mistake. Because Calcite assumes that an `ANY` type does not need further parameters and `BasicSqlType` can be used a an instance class. The `ANY` type belongs to pure `Object.class` without any further parameters. I currently don't see a reason why we should come up with an arbitrary mapping to an enum value if this is actually not a SQL type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services