[GitHub] [dubbo] guohao commented on a diff in pull request #9945: [3.0] tri support Bzip2

[GitBox <gi...@apache.org>]

guohao commented on code in PR #9945:
URL: https://github.com/apache/dubbo/pull/9945#discussion_r853693947


##########
dubbo-rpc/dubbo-rpc-triple/pom.xml:
##########
@@ -59,6 +59,11 @@
             <version>3.4.16</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-compress</artifactId>
+            <version>1.21</version>

Review Comment:
   1. The `version` needs to be specified in `bom`'s `pom.xml` 
   2. May `optional` or `compileOnly` scope will be better to reduce indirect deps of Dubbo? Users can  import it manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org