[GitHub] [apisix] windyrjc commented on a change in pull request #5501: feat: kafka logger supports logging request body (#5343)

[GitBox <gi...@apache.org>]

windyrjc commented on a change in pull request #5501:
URL: https://github.com/apache/apisix/pull/5501#discussion_r748847942



##########
File path: apisix/utils/log-util.lua
##########
@@ -119,13 +120,32 @@ local function get_full_log(ngx, conf)
     }
 
     if conf.include_req_body then

Review comment:
       In my opinion, i think `include_req_body` like a main switch, `include_req_body_expr` like a switch in condition. Close  `include_req_body`  will not log any request body data, and `include_req_body`'s semantic is compatible with  the previous version of kafka-logger, we are just only add a condition expr.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org