You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/17 04:32:19 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6069: RISC-V: Add support for CONFIG_BUILD_KERNEL
xiaoxiang781216 commented on code in PR #6069:
URL: https://github.com/apache/incubator-nuttx/pull/6069#discussion_r851700651
##########
arch/risc-v/src/common/riscv_addrenv.c:
##########
@@ -187,6 +193,38 @@ static int create_spgtables(group_addrenv_t *addrenv)
return i;
}
+/****************************************************************************
+ * Name: copy_kernel_mappings
+ *
+ * Description:
+ * Copy kernel mappings to address environment. Expects that the user page
+ * table does not contain any mappings yet (as they will be wiped).
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment. The page tables must exist
+ * at this point.
+ *
+ * Returned value:
+ * OK on success, ERROR on failure
+ *
+ ****************************************************************************/
+
+static int copy_kernel_mappings(group_addrenv_t *addrenv)
+{
+ uintptr_t user_mappings = addrenv->spgtables[0];
+
+ /* Copy the L1 references */
+
+ if (user_mappings == 0)
+ {
+ return ERROR;
+ }
+
+ memcpy((void *)user_mappings, (void *)g_kernel_mappings, ENTRIES_PER_PGT);
Review Comment:
should we copy byte size instead entries(ENTRIES_PER_PGT)?
##########
arch/z80/src/z180/z180_mmu.c:
##########
@@ -375,6 +375,33 @@ int up_addrenv_vdata(FAR group_addrenv_t *addrenv, uintptr_t textsize,
return CONFIG_Z180_COMMON1AREA_VIRTBASE + textsize;
}
+/****************************************************************************
+ * Name: up_addrenv_vheap
+ *
+ * Description:
+ * Return the heap virtual address associated with the newly created
+ * address environment. This function is used by the binary loaders in
+ * order get an address that can be used to initialize the new task.
+ *
+ * Input Parameters:
+ * addrenv - The representation of the task address environment previously
+ * returned by up_addrenv_create.
+ * vheap - The location to return the virtual address.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_BUILD_KERNEL
+int up_addrenv_vheap(FAR const group_addrenv_t *addrenv, FAR void **vheap)
+{
+ /* Not implemented */
+
+ return (ssize_t)-ENOSYS;
Review Comment:
should we return the correct value here?
##########
arch/risc-v/src/common/riscv_addrenv.c:
##########
@@ -0,0 +1,828 @@
+/****************************************************************************
+ * arch/risc-v/src/common/riscv_addrenv.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Address Environment Interfaces
+ *
+ * Low-level interfaces used in binfmt/ to instantiate tasks with address
+ * environments. These interfaces all operate on type group_addrenv_t which
+ * is an abstract representation of a task group's address environment and
+ * must be defined in arch/arch.h if CONFIG_ARCH_ADDRENV is defined.
+ *
+ * up_addrenv_create - Create an address environment
+ * up_addrenv_destroy - Destroy an address environment.
+ * up_addrenv_vtext - Returns the virtual base address of the .text
+ * address environment
+ * up_addrenv_vdata - Returns the virtual base address of the .bss/.data
+ * address environment
+ * up_addrenv_heapsize - Returns the size of the initial heap allocation.
+ * up_addrenv_select - Instantiate an address environment
+ * up_addrenv_restore - Restore an address environment
+ * up_addrenv_clone - Copy an address environment from one location to
+ * another.
+ *
+ * Higher-level interfaces used by the tasking logic. These interfaces are
+ * used by the functions in sched/ and all operate on the thread which whose
+ * group been assigned an address environment by up_addrenv_clone().
+ *
+ * up_addrenv_attach - Clone the address environment assigned to one TCB
+ * to another. This operation is done when a pthread
+ * is created that share's the same address
+ * environment.
+ * up_addrenv_detach - Release the threads reference to an address
+ * environment when a task/thread exits.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <errno.h>
+#include <assert.h>
+#include <debug.h>
+
+#include <nuttx/addrenv.h>
+#include <nuttx/arch.h>
+#include <nuttx/irq.h>
+#include <nuttx/pgalloc.h>
+
+#include <arch/barriers.h>
+
+#include "pgalloc.h"
+#include "riscv_mmu.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* Only CONFIG_BUILD_KERNEL is supported (i.e. tested) */
+
+#ifndef CONFIG_BUILD_KERNEL
+# error "This module is intended to be used with CONFIG_BUILD_KERNEL"
+#endif
+
+/* Entries per PGT */
+
+#define ENTRIES_PER_PGT (RV_MMU_ENTRIES_PER_PGT)
+
+/* Base address for address environment */
+
+#define ADDRENV_VBASE (CONFIG_ARCH_DATA_VBASE)
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+extern uintptr_t g_kernel_mappings;
+
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: wipe_page
+ *
+ * Description:
+ * Wipe a page of physical memory, first mapping it into virtual memory.
+ *
+ * Input Parameters:
+ * paddr - Physical address of page
+ *
+ ****************************************************************************/
+
+static inline void wipe_page(uintptr_t paddr)
+{
+ uintptr_t vaddr = riscv_pgpool_to_vaddr(paddr);
+ memset((void *)vaddr, 0, MM_PGSIZE);
+}
+
+/****************************************************************************
+ * Name: map_spgtables
+ *
+ * Description:
+ * Map vaddr to the static page tables.
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment
+ *
+ ****************************************************************************/
+
+static void map_spgtables(group_addrenv_t *addrenv, uintptr_t vaddr)
+{
+ int i;
+ uintptr_t prev;
+
+ /* Start from L1, and connect until max level - 1 */
+
+ prev = riscv_pgpool_to_vaddr(addrenv->spgtables[0]);
+
+ /* Check if the mapping already exists */
+
+ if (mmu_ln_getentry(1, prev, vaddr) != 0)
+ {
+ return;
+ }
+
+ /* No mapping yet, create it */
+
+ for (i = 0; i < (ARCH_SPGTS - 1); i++)
+ {
+ uintptr_t next = riscv_pgpool_to_vaddr(addrenv->spgtables[i + 1]);
+ mmu_ln_setentry(i + 1, prev, next, vaddr, MMU_UPGT_FLAGS);
+ prev = next;
+ }
+}
+
+/****************************************************************************
+ * Name: create_spgtables
+ *
+ * Description:
+ * Create the static page tables. Allocate memory for them and connect them
+ * together.
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment
+ *
+ * Returned value:
+ * Amount of pages created on success; a negated errno value on failure
+ *
+ ****************************************************************************/
+
+static int create_spgtables(group_addrenv_t *addrenv)
+{
+ int i;
+ uintptr_t paddr;
+
+ for (i = 0; i < ARCH_SPGTS; i++)
+ {
+ paddr = mm_pgalloc(1);
+ if (!paddr)
+ {
+ return -ENOMEM;
+ }
+
+ /* Wipe the memory and assign it */
+
+ wipe_page(paddr);
+ addrenv->spgtables[i] = paddr;
+ }
+
+ /* Flush the data cache, so the changes are committed to memory */
+
+ __DMB();
+
+ return i;
+}
+
+/****************************************************************************
+ * Name: copy_kernel_mappings
+ *
+ * Description:
+ * Copy kernel mappings to address environment. Expects that the user page
+ * table does not contain any mappings yet (as they will be wiped).
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment. The page tables must exist
+ * at this point.
+ *
+ * Returned value:
+ * OK on success, ERROR on failure
+ *
+ ****************************************************************************/
+
+static int copy_kernel_mappings(group_addrenv_t *addrenv)
+{
+ uintptr_t user_mappings = riscv_pgpool_to_vaddr(addrenv->spgtables[0]);
+
+ /* Copy the L1 references */
+
+ if (user_mappings == 0)
+ {
+ return ERROR;
+ }
+
+ memcpy((void *)user_mappings, (void *)g_kernel_mappings, ENTRIES_PER_PGT);
+
+ return OK;
+}
+
+/****************************************************************************
+ * Name: create_region
+ *
+ * Description:
+ * Map a single region of memory to MMU. Assumes that the static page
+ * tables exist. Allocates the final level page tables and commits the
+ * region memory to physical memory.
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment
+ * vaddr - Base virtual address for the mapping
+ * size - Size of the region in bytes
+ * mmuflags - MMU flags to use
+ *
+ * Returned value:
+ * Amount of pages created on success; a negated errno value on failure
+ *
+ ****************************************************************************/
+
+static int create_region(group_addrenv_t *addrenv, uintptr_t vaddr,
+ size_t size, uint32_t mmuflags)
+{
+ uintptr_t ptlast;
+ uintptr_t ptprev;
+ uintptr_t paddr;
+ uint32_t ptlevel;
+ int npages;
+ int nmapped;
+ int i;
+ int j;
+
+ nmapped = 0;
+ npages = MM_NPAGES(size);
+ ptprev = riscv_pgpool_to_vaddr(addrenv->spgtables[ARCH_SPGTS - 1]);
+ ptlevel = ARCH_SPGTS;
+
+ /* Create mappings for the lower level tables */
+
+ map_spgtables(addrenv, vaddr);
+
+ /* Begin allocating memory for the page tables */
+
+ for (i = 0; i < npages; i += ENTRIES_PER_PGT)
+ {
+ /* Get the current final level entry corresponding to this vaddr */
+
+ paddr = mmu_pte_to_paddr(mmu_ln_getentry(ptlevel, ptprev, vaddr));
+
+ if (paddr == 0)
+ {
+ /* Nothing yet, allocate one page for final level page table */
+
+ paddr = mm_pgalloc(1);
+ if (!paddr)
+ {
+ return -ENOMEM;
+ }
+
+ /* Map the page table to the prior level */
+
+ mmu_ln_setentry(ptlevel, ptprev, paddr, vaddr, MMU_UPGT_FLAGS);
+
+ /* This is then used to map the final level */
+
+ wipe_page(paddr);
+ }
+
+ ptlast = riscv_pgpool_to_vaddr(paddr);
+
+ /* Then allocate memory for the region data */
+
+ for (j = 0; j < ENTRIES_PER_PGT && nmapped < size; j++)
+ {
+ paddr = mm_pgalloc(1);
+ if (!paddr)
+ {
+ return -ENOMEM;
+ }
+
+ /* Wipe the physical page memory */
+
+ wipe_page(paddr);
+
+ /* Then map the virtual address to the physical address */
+
+ mmu_ln_setentry(ptlevel + 1, ptlast, paddr, vaddr, mmuflags);
+ nmapped += MM_PGSIZE;
+ vaddr += MM_PGSIZE;
+ }
+ }
+
+ /* Flush the data cache, so the changes are committed to memory */
+
+ __DMB();
+
+ return npages;
+}
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: up_addrenv_create
+ *
+ * Description:
+ * This function is called when a new task is created in order to
+ * instantiate an address environment for the new task group.
+ * up_addrenv_create() is essentially the allocator of the physical
+ * memory for the new task.
+ *
+ * Input Parameters:
+ * textsize - The size (in bytes) of the .text address environment needed
+ * by the task. This region may be read/execute only.
+ * datasize - The size (in bytes) of the .data/.bss address environment
+ * needed by the task. This region may be read/write only. NOTE: The
+ * actual size of the data region that is allocated will include a
+ * OS private reserved region at the beginning. The size of the
+ * private, reserved region is give by ARCH_DATA_RESERVE_SIZE.
+ * heapsize - The initial size (in bytes) of the heap address environment
+ * needed by the task. This region may be read/write only.
+ * addrenv - The location to return the representation of the task address
+ * environment.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize,
+ FAR group_addrenv_t *addrenv)
+{
+ int ret;
+ uintptr_t resvbase;
+ uintptr_t resvsize;
+ uintptr_t textbase;
+ uintptr_t database;
+ uintptr_t heapbase;
+
+ DEBUGASSERT(addrenv);
+ DEBUGASSERT(MM_ISALIGNED(ADDRENV_VBASE));
+
+ /* Make sure the address environment is wiped before doing anything */
+
+ memset(addrenv, 0, sizeof(group_addrenv_t));
+
+ /* Create the static page tables */
+
+ if (create_spgtables(addrenv) < 0)
+ {
+ serr("ERROR: Failed to create static page tables\n");
+ ret = -ENOMEM;
+ goto errout;
+ }
+
+ if (copy_kernel_mappings(addrenv) < 0)
+ {
+ serr("ERROR: Failed to copy kernel mappings to new environment");
+ ret = -EINVAL;
+ goto errout;
+ }
+
+ /* Calculate the base addresses for convenience */
+
+ resvbase = ADDRENV_VBASE;
+ resvsize = ARCH_DATA_RESERVE_SIZE;
+ textbase = resvbase + MM_PGALIGNUP(resvsize);
+ database = textbase + MM_PGALIGNUP(textsize);
+ heapbase = database + MM_PGALIGNUP(datasize);
+
+ /* Allocate 1 extra page for heap, temporary fix for #5811 */
+
+ heapsize = heapsize + MM_NPAGES(1);
+
+ /* Map the reserved area */
+
+ ret = create_region(addrenv, resvbase, resvsize, MMU_UDATA_FLAGS);
+
+ if (ret < 0)
+ {
+ berr("ERROR: Failed to create reserved region: %d\n", ret);
+ goto errout;
+ }
+
+ /* Map each region in turn FIXME: Remove W-flag after .elf is loaded */
+
+ ret = create_region(addrenv, textbase, textsize, MMU_UTEXT_FLAGS | PTE_W);
+
+ if (ret < 0)
+ {
+ berr("ERROR: Failed to create .text region: %d\n", ret);
+ goto errout;
+ }
+
+ ret = create_region(addrenv, database, datasize, MMU_UDATA_FLAGS);
+
+ if (ret < 0)
+ {
+ berr("ERROR: Failed to create .bss/.data region: %d\n", ret);
+ goto errout;
+ }
+
+ ret = create_region(addrenv, heapbase, heapsize, MMU_UDATA_FLAGS);
+
+ if (ret < 0)
+ {
+ berr("ERROR: Failed to create heap region: %d\n", ret);
+ goto errout;
+ }
+
+ /* Save the heap base and initial size allocated. These will be needed when
+ * the heap data structures are initialized.
+ */
+
+ addrenv->heapvbase = heapbase;
+ addrenv->heapsize = (size_t)ret << MM_PGSHIFT;
+
+ /* Save the text base */
+
+ addrenv->textvbase = textbase;
+
+ /* Save the data base */
+
+ addrenv->datavbase = database;
+
+ /* Provide the satp value for context switch */
+
+ addrenv->satp = mmu_satp_reg(addrenv->spgtables[0], 0);
+
+ /* When all is set and done, flush the data caches */
+
+ __ISB();
+ __DMB();
+
+ return OK;
+
+errout:
+ up_addrenv_destroy(addrenv);
+ return ret;
+}
+
+/****************************************************************************
+ * Name: up_addrenv_destroy
+ *
+ * Description:
+ * This function is called when a final thread leaves the task group and
+ * the task group is destroyed. This function then destroys the defunct
+ * address environment, releasing the underlying physical memory.
+ *
+ * Input Parameters:
+ * addrenv - The address environment to be destroyed.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+int up_addrenv_destroy(FAR group_addrenv_t *addrenv)
+{
+ /* Recursively destroy it all, need to table walk */
+
+ uintptr_t *ptprev;
+ uintptr_t *ptlast;
+ uintptr_t paddr;
+ int i;
+ int j;
+
+ DEBUGASSERT(addrenv);
+
+ /* Make sure the caches are flushed before doing this */
+
+ __ISB();
+ __DMB();
+
+ /* First destroy the allocated memory and the final level page table */
+
+ ptprev = (uintptr_t *)addrenv->spgtables[ARCH_SPGTS - 1];
+ if (ptprev)
+ {
+ for (i = 0; i < ENTRIES_PER_PGT; i++)
+ {
+ ptlast = (uintptr_t *)mmu_pte_to_paddr(ptprev[i]);
+ if (ptlast)
+ {
+ /* Page table allocated, free any allocated memory */
+
+ for (j = 0; j < ENTRIES_PER_PGT; j++)
+ {
+ paddr = mmu_pte_to_paddr(ptlast[j]);
+ if (paddr)
+ {
+ mm_pgfree(paddr, 1);
+ }
+ }
+
+ /* Then free the page table itself */
+
+ mm_pgfree((uintptr_t)ptlast, 1);
+ }
+ }
+ }
+
+ /* Then destroy the static tables */
+
+ for (i = 0; i < ARCH_SPGTS; i++)
+ {
+ paddr = addrenv->spgtables[i];
+ if (paddr)
+ {
+ mm_pgfree(paddr, 1);
+ }
+ }
+
+ /* When all is set and done, flush the caches */
+
+ __ISB();
+ __DMB();
+
+ memset(addrenv, 0, sizeof(group_addrenv_t));
+ return OK;
+}
+
+/****************************************************************************
+ * Name: up_addrenv_vtext
+ *
+ * Description:
+ * Return the virtual address associated with the newly create .text
+ * address environment. This function is used by the binary loaders in
+ * order get an address that can be used to initialize the new task.
+ *
+ * Input Parameters:
+ * addrenv - The representation of the task address environment previously
+ * returned by up_addrenv_create.
+ * vtext - The location to return the virtual address.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+int up_addrenv_vtext(FAR group_addrenv_t *addrenv, FAR void **vtext)
+{
+ DEBUGASSERT(addrenv && vtext);
+ *vtext = (FAR void *)addrenv->textvbase;
+ return OK;
+}
+
+/****************************************************************************
+ * Name: up_addrenv_vdata
+ *
+ * Description:
+ * Return the virtual address associated with the newly create .text
+ * address environment. This function is used by the binary loaders in
+ * order get an address that can be used to initialize the new task.
+ *
+ * Input Parameters:
+ * addrenv - The representation of the task address environment previously
+ * returned by up_addrenv_create.
+ * textsize - For some implementations, the text and data will be saved
+ * in the same memory region (read/write/execute) and, in this case,
+ * the virtual address of the data just lies at this offset into the
+ * common region.
+ * vdata - The location to return the virtual address.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+int up_addrenv_vdata(FAR group_addrenv_t *addrenv, uintptr_t textsize,
+ FAR void **vdata)
+{
+ DEBUGASSERT(addrenv && vdata);
+ *vdata = (FAR void *)addrenv->datavbase;
+ return OK;
+}
+
+/****************************************************************************
+ * Name: up_addrenv_vheap
+ *
+ * Description:
+ * Return the heap virtual address associated with the newly created
+ * address environment. This function is used by the binary loaders in
+ * order get an address that can be used to initialize the new task.
+ *
+ * Input Parameters:
+ * addrenv - The representation of the task address environment previously
+ * returned by up_addrenv_create.
+ * vheap - The location to return the virtual address.
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_BUILD_KERNEL
+int up_addrenv_vheap(FAR const group_addrenv_t *addrenv, FAR void **vheap)
+{
+ DEBUGASSERT(addrenv && vheap);
+ *vheap = (FAR void *)addrenv->heapvbase;
Review Comment:
all FAR need remove from this file?
##########
arch/risc-v/src/common/riscv_addrenv.c:
##########
@@ -342,6 +380,13 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize,
goto errout;
}
+ if (copy_kernel_mappings(addrenv) < 0)
Review Comment:
ret = copy_kernel_mappings(addrenv);
if (ret < 0)
{
serr("ERROR: Failed to copy kernel mappings to new environment");
goto errout;
}
##########
arch/risc-v/src/common/riscv_addrenv.c:
##########
@@ -187,6 +193,38 @@ static int create_spgtables(group_addrenv_t *addrenv)
return i;
}
+/****************************************************************************
+ * Name: copy_kernel_mappings
+ *
+ * Description:
+ * Copy kernel mappings to address environment. Expects that the user page
+ * table does not contain any mappings yet (as they will be wiped).
+ *
+ * Input Parameters:
+ * addrenv - Describes the address environment. The page tables must exist
+ * at this point.
+ *
+ * Returned value:
+ * OK on success, ERROR on failure
+ *
+ ****************************************************************************/
+
+static int copy_kernel_mappings(group_addrenv_t *addrenv)
+{
+ uintptr_t user_mappings = addrenv->spgtables[0];
+
+ /* Copy the L1 references */
+
+ if (user_mappings == 0)
+ {
+ return ERROR;
Review Comment:
return -EINVAL directly
##########
arch/risc-v/src/common/riscv_mmu.h:
##########
@@ -26,6 +26,10 @@
#define RV_MMU_PAGE_SHIFT (12)
#define RV_MMU_PAGE_SIZE (1 << RV_MMU_PAGE_SHIFT) /* 4K pages */
+/* Entries per PGT */
+
+#define RV_MMU_ENTRIES_PER_PGT (RV_MMU_PAGE_SIZE / sizeof(uintptr_t))
Review Comment:
RV_MMU_ENTRIES_PER_PGT->RV_MMU_PAGE_ENTRIES?
##########
arch/risc-v/src/common/riscv_addrenv_util.c:
##########
@@ -0,0 +1,57 @@
+/****************************************************************************
+ * arch/risc-v/src/common/riscv_addrenv_util.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <arch/board/board_memorymap.h>
+
+#include "pgalloc.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: riscv_pgpool_to_vaddr
+ *
+ * Description:
+ * Convert physical page pool address to virtual page pool address
+ *
+ * Input Parameters:
+ * paddr - The physical address to convert
+ *
+ * Returned Value:
+ * Page pool virtual address, or 0 if paddr is not within page pool
+ *
+ ****************************************************************************/
+
+uintptr_t riscv_pgpool_to_vaddr(uintptr_t paddr)
Review Comment:
why not follow arm_pgvaddr implementation? I mean:
1. Name it riscv_pgvaddr
2. Use CONFIG_ARCH_PGPOOL_PBASE and CONFIG_ARCH_PGPOOL_VBASE
3. Implement as macro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org