You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe Jr." <wr...@rowe-clan.net> on 2011/09/01 03:51:03 UTC

Re: Appropriate patches for 2.2.19 and 2.0.64?

On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
> I've attempted to simply substitute the 2.2.19 filter code into the
> 2.0.64 http_protocol.c sources, and am unsure how far off these patches
> are from what they need to be; there's been a significant amount of drift
> and refactoring in the interim.

Still looking for feedback, but the attached applies and corresponds to
2.2.20 with the exception of atoi rather than strtoi semantics, and without
the no DefaultType exception..



Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Rainer Jung <ra...@kippdata.de>.
On 10.09.2011 15:00, William A. Rowe Jr. wrote:
> On 9/6/2011 4:24 PM, William A. Rowe Jr. wrote:
>> On 9/6/2011 9:01 AM, Jeff Trawick wrote:
>>>
>>> I can take care of T&R of APR 0.9.20 in a couple of days provided that
>>> someone first gets CVE-2011-1928 resolved in that branch.
>>
>> That's already done for some time now;
>>
>>   http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/
>>
>> although I still need to update CHANGES already.
> 
> Now changed, and rechecked our merged rev.  This looks good to go
> if you would like to move forwards.
> 
> Did anyone else have immediate concerns for this 0.9 branch?

I just did a quick check for the current 0.9.x heads:

1) APR
======

make check (testall) crashes when buildingout of tree, because test/data
isn't found. If I copy it in, I get one failure:

Failed tests in Socket Creation:
1) sendto_receivefrom: expected <0> but was <126>

But that's not a regression from 0.9.19.

2) APU-UTIL
===========

Builds and checks fine.


3) APR-ICONV
============

Build fails:

.../r1167521/./lib/iconv_ces_euc.c: In function 'apr_iconv_euc_open':
.../r1167521/./lib/iconv_ces_euc.c:65: error: invalid lvalue in assignment

Line is:

CESTOSTATE(ces) = state;

which is

((iconv_ces_euc_state_t *)(ces)->data) = state;

It is old code, so probably not a regression. IMHO the fix would be:

Index:
/shared/build/dev/httpd/sources/apr-iconv/0.9.x/r1167521/lib/iconv_ces_euc.c
===================================================================
---
/shared/build/dev/httpd/sources/apr-iconv/0.9.x/r1167521/lib/iconv_ces_euc.c
       (revision 1167521)
+++
/shared/build/dev/httpd/sources/apr-iconv/0.9.x/r1167521/lib/iconv_ces_euc.c
       (working copy)
@@ -62,7 +62,7 @@
        state->nccs = ces->mod->im_depcnt;
        for (i = ces->mod->im_depcnt; i; i--, depmod = depmod->im_next)
                state->ccs[i - 1] = depmod;
-       CESTOSTATE(ces) = state;
+       ces->data = (void *)state;
        return APR_SUCCESS;
 }

and then again

.../r1167521/./ces/ucs2-internal.c: In function 'convert_from_ucs':
.../r1167521/./ces/ucs2-internal.c:62: error: invalid lvalue in increment
.../r1167521/./ces/ucs2-internal.c: In function 'convert_to_ucs':
.../r1167521/./ces/ucs2-internal.c:74: error: invalid lvalue in increment

Haven't checked those for fixes yet. Need to rush for something to eat
now :)

Regards,

Rainer

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sun, Sep 11, 2011 at 9:10 PM, William A. Rowe Jr.
<wr...@rowe-clan.net> wrote:
> On 9/11/2011 7:18 PM, Jeff Trawick wrote:
>>>
>>> I'll plan to get started looking for concerns and rolling in time to
>>> have candidates available before I leave for Redwood Shores early
>>> Monday.
>>
>> err, add 1 day to that estimate :(
>
> I hope you aren't deferring your departure?  I'm happy to T&R apr
> if it lets you out of town that much sooner (and I'm sure there
> are others who would be equally willing to help you to vacation!)

not vacation unfortunately, and not deferred...  I just need to T&R
Monday evening instead of Sunday evening (sorry for the obliqueness)

if anyone wants to go ahead during the day then great; otherwise I
should be okay this evening

thanks!

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/11/2011 7:18 PM, Jeff Trawick wrote:
>>
>> I'll plan to get started looking for concerns and rolling in time to
>> have candidates available before I leave for Redwood Shores early
>> Monday.
> 
> err, add 1 day to that estimate :(

I hope you aren't deferring your departure?  I'm happy to T&R apr
if it lets you out of town that much sooner (and I'm sure there
are others who would be equally willing to help you to vacation!)

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sat, Sep 10, 2011 at 10:53 AM, Jeff Trawick <tr...@gmail.com> wrote:
> On Sat, Sep 10, 2011 at 9:00 AM, William A. Rowe Jr.
> <wr...@rowe-clan.net> wrote:
>> On 9/6/2011 4:24 PM, William A. Rowe Jr. wrote:
>>> On 9/6/2011 9:01 AM, Jeff Trawick wrote:
>>>>
>>>> I can take care of T&R of APR 0.9.20 in a couple of days provided that
>>>> someone first gets CVE-2011-1928 resolved in that branch.
>>>
>>> That's already done for some time now;
>>>
>>>   http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/
>>>
>>> although I still need to update CHANGES already.
>>
>> Now changed, and rechecked our merged rev.  This looks good to go
>> if you would like to move forwards.
>
> I'll plan to get started looking for concerns and rolling in time to
> have candidates available before I leave for Redwood Shores early
> Monday.

err, add 1 day to that estimate :(

>
>>
>> Did anyone else have immediate concerns for this 0.9 branch?
>>
>>> I hadn't attempted to port fnmatch tests to CuTest, if anyone is
>>> interested in doing so, be my guest.
>>
>> No interest in porting, here, I don't see a whole lot of reasons
>> to do so as the code is effectively identical.
>>
>
> Maybe I'll hack something up just quick enough to check for mortal
> embarrassment.  (A bit of cut and paste and #define should suffice.)
>
>
> --
> Born in Roswell... married an alien...
>



-- 
Born in Roswell... married an alien...

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sat, Sep 10, 2011 at 10:53 AM, Jeff Trawick <tr...@gmail.com> wrote:
> On Sat, Sep 10, 2011 at 9:00 AM, William A. Rowe Jr.
> <wr...@rowe-clan.net> wrote:
>> On 9/6/2011 4:24 PM, William A. Rowe Jr. wrote:
>>> On 9/6/2011 9:01 AM, Jeff Trawick wrote:
>>>>
>>>> I can take care of T&R of APR 0.9.20 in a couple of days provided that
>>>> someone first gets CVE-2011-1928 resolved in that branch.
>>>
>>> That's already done for some time now;
>>>
>>>   http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/
>>>
>>> although I still need to update CHANGES already.
>>
>> Now changed, and rechecked our merged rev.  This looks good to go
>> if you would like to move forwards.
>
> I'll plan to get started looking for concerns and rolling in time to
> have candidates available before I leave for Redwood Shores early
> Monday.
>
>>
>> Did anyone else have immediate concerns for this 0.9 branch?
>>
>>> I hadn't attempted to port fnmatch tests to CuTest, if anyone is
>>> interested in doing so, be my guest.
>>
>> No interest in porting, here, I don't see a whole lot of reasons
>> to do so as the code is effectively identical.
>>
>
> Maybe I'll hack something up just quick enough to check for mortal
> embarrassment.  (A bit of cut and paste and #define should suffice.)

test_fnmatch() and test_fnmatch_test() from 1.4.x branch are happy,
after a bit of quick hackery

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sat, Sep 10, 2011 at 9:00 AM, William A. Rowe Jr.
<wr...@rowe-clan.net> wrote:
> On 9/6/2011 4:24 PM, William A. Rowe Jr. wrote:
>> On 9/6/2011 9:01 AM, Jeff Trawick wrote:
>>>
>>> I can take care of T&R of APR 0.9.20 in a couple of days provided that
>>> someone first gets CVE-2011-1928 resolved in that branch.
>>
>> That's already done for some time now;
>>
>>   http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/
>>
>> although I still need to update CHANGES already.
>
> Now changed, and rechecked our merged rev.  This looks good to go
> if you would like to move forwards.

I'll plan to get started looking for concerns and rolling in time to
have candidates available before I leave for Redwood Shores early
Monday.

>
> Did anyone else have immediate concerns for this 0.9 branch?
>
>> I hadn't attempted to port fnmatch tests to CuTest, if anyone is
>> interested in doing so, be my guest.
>
> No interest in porting, here, I don't see a whole lot of reasons
> to do so as the code is effectively identical.
>

Maybe I'll hack something up just quick enough to check for mortal
embarrassment.  (A bit of cut and paste and #define should suffice.)


-- 
Born in Roswell... married an alien...

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/6/2011 4:24 PM, William A. Rowe Jr. wrote:
> On 9/6/2011 9:01 AM, Jeff Trawick wrote:
>>
>> I can take care of T&R of APR 0.9.20 in a couple of days provided that
>> someone first gets CVE-2011-1928 resolved in that branch.
> 
> That's already done for some time now;
> 
>   http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/
> 
> although I still need to update CHANGES already.

Now changed, and rechecked our merged rev.  This looks good to go
if you would like to move forwards.

Did anyone else have immediate concerns for this 0.9 branch?

> I hadn't attempted to port fnmatch tests to CuTest, if anyone is
> interested in doing so, be my guest.

No interest in porting, here, I don't see a whole lot of reasons
to do so as the code is effectively identical.

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/6/2011 9:01 AM, Jeff Trawick wrote:
> 
> I can take care of T&R of APR 0.9.20 in a couple of days provided that
> someone first gets CVE-2011-1928 resolved in that branch.

That's already done for some time now;

  http://svn.apache.org/viewvc/apr/apr/branches/0.9.x/strings/

although I still need to update CHANGES already.

I hadn't attempted to port fnmatch tests to CuTest, if anyone is
interested in doing so, be my guest.


Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sun, Sep 4, 2011 at 7:26 PM, William A. Rowe Jr. <wr...@rowe-clan.net> wrote:
> On 9/3/2011 2:49 PM, Jeff Trawick wrote:
>>
>> With this fix, I get no testcase failures and this skippage:
>
> Bingo, stared at that code for hours, finally realized I had
> re-extracted a -2.2 labeled patch instead of correcting the -2.0
> patch... argh!!!
>
> Will incorporate the past couple of trunk/2.2 corrections and
> propose for backport... if accepted we'll post it as the official
> apply_to_2.0.64 patch, with or without a .65 tag.  Will also suggest
> we tag apr 0.9.20 in the coming few days so if anyone wants to work
> in any other corrections, do so in the very near term.

Any idea when you will have time/inclination to update the 2.0.64
patch?  I expect to have a bit of time to spend either working on the
patch or testing it.

I can take care of T&R of APR 0.9.20 in a couple of days provided that
someone first gets CVE-2011-1928 resolved in that branch.

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Sun, Sep 4, 2011 at 7:26 PM, William A. Rowe Jr. <wr...@rowe-clan.net> wrote:
> On 9/3/2011 2:49 PM, Jeff Trawick wrote:
>>
>> With this fix, I get no testcase failures and this skippage:
>
> Bingo, stared at that code for hours, finally realized I had
> re-extracted a -2.2 labeled patch instead of correcting the -2.0
> patch... argh!!!
>
> Will incorporate the past couple of trunk/2.2 corrections and
> propose for backport... if accepted we'll post it as the official
> apply_to_2.0.64 patch, with or without a .65 tag.  Will also suggest
> we tag apr 0.9.20 in the coming few days so if anyone wants to work
> in any other corrections, do so in the very near term.

Any idea when you will have time/inclination to update the 2.0.64
patch?  I expect to have a bit of time to spend either working on the
patch or testing it.

I can take care of T&R of APR 0.9.20 in a couple of days provided that
someone first gets CVE-2011-1928 resolved in that branch.

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/3/2011 2:49 PM, Jeff Trawick wrote:
> 
> With this fix, I get no testcase failures and this skippage:

Bingo, stared at that code for hours, finally realized I had
re-extracted a -2.2 labeled patch instead of correcting the -2.0
patch... argh!!!

Will incorporate the past couple of trunk/2.2 corrections and
propose for backport... if accepted we'll post it as the official
apply_to_2.0.64 patch, with or without a .65 tag.  Will also suggest
we tag apr 0.9.20 in the coming few days so if anyone wants to work
in any other corrections, do so in the very near term.



Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/3/2011 2:49 PM, Jeff Trawick wrote:
> 
> With this fix, I get no testcase failures and this skippage:

Bingo, stared at that code for hours, finally realized I had
re-extracted a -2.2 labeled patch instead of correcting the -2.0
patch... argh!!!

Will incorporate the past couple of trunk/2.2 corrections and
propose for backport... if accepted we'll post it as the official
apply_to_2.0.64 patch, with or without a .65 tag.  Will also suggest
we tag apr 0.9.20 in the coming few days so if anyone wants to work
in any other corrections, do so in the very near term.



Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Rainer Jung <ra...@kippdata.de>.
On 03.09.2011 21:49, Jeff Trawick wrote:
> On Wed, Aug 31, 2011 at 9:51 PM, William A. Rowe Jr.
> <wr...@rowe-clan.net> wrote:
>> On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
>>> I've attempted to simply substitute the 2.2.19 filter code into the
>>> 2.0.64 http_protocol.c sources, and am unsure how far off these patches
>>> are from what they need to be; there's been a significant amount of drift
>>> and refactoring in the interim.
>>
>> Still looking for feedback, but the attached applies and corresponds to
>> 2.2.20 with the exception of atoi rather than strtoi semantics, and without
>> the no DefaultType exception..
> 
> Here's some more feedback :)  The commented-out line below in the
> middle of your patch is borked, as the variable range has been moved
> through the string being parsed by ap_getword().  cur is what we're
> parsing this time through the loop, reflected in my minor
> modification (the next line).

...

> With this fix, I get no testcase failures and this skippage:
> 
> t/apache/byterange.t ........ ok
> t/apache/byterange2.t ....... ok
> t/apache/byterange3.t ....... skipped: (no reason given)
> t/apache/byterange4.t ....... ok
> t/apache/byterange5.t ....... ok
> t/apache/byterange6.t ....... skipped: apache version 2.3.15 or higher
> is required, this is version 2.0.65
> t/apache/byterange7.t ....... ok

Same here, at least no more failures for Range related tests using the
updated patch.

> Thanks for putting this together so that there was something to try out!!!!

+1

Rainer

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, Aug 31, 2011 at 9:51 PM, William A. Rowe Jr.
<wr...@rowe-clan.net> wrote:
> On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
>> I've attempted to simply substitute the 2.2.19 filter code into the
>> 2.0.64 http_protocol.c sources, and am unsure how far off these patches
>> are from what they need to be; there's been a significant amount of drift
>> and refactoring in the interim.
>
> Still looking for feedback, but the attached applies and corresponds to
> 2.2.20 with the exception of atoi rather than strtoi semantics, and without
> the no DefaultType exception..

Here's some more feedback :)  The commented-out line below in the
middle of your patch is borked, as the variable range has been moved
through the string being parsed by ap_getword().  cur is what we're
parsing this time through the loop, reflected in my minor
modification (the next line).

+        if (dash == range) {
+            /* In the form "-5" */
+            start = clength - apr_atoi64(dash + 1);
+            end = clength - 1;
+        }
+        else {
+            *dash++ = '\0';
+            /* wrowe: start = apr_atoi64(range); */
+            start = apr_atoi64(cur);
+            if (*dash) {
+                end = apr_atoi64(dash);
+            }
+            else {                  /* "5-" */
+                end = clength - 1;
+            }
+        }
+

Without this fix, I get this for the byterange tests against 2.0.x HEAD + patch:

t/apache/byterange.t      (Wstat: 0 Tests: 165 Failed: 121)
  Failed tests:  2-11, 13, 19-29, 31-32, 37-38, 40-41, 46-48
                50-53, 55, 57-60, 62-74, 76-80, 82-83, 85-88
                92, 94-95, 98-104, 107-110, 112-114, 116-118
                120-122, 125-135, 137-150, 153-155, 157
                159, 161, 163-165
t/apache/byterange4.t     (Wstat: 0 Tests: 153 Failed: 136)
  Failed tests:  18-153
t/apache/byterange5.t     (Wstat: 0 Tests: 5 Failed: 4)
  Failed tests:  1, 3-5
t/apache/byterange7.t     (Wstat: 0 Tests: 13 Failed: 5)
  Failed tests:  2-5, 12

With this fix, I get no testcase failures and this skippage:

t/apache/byterange.t ........ ok
t/apache/byterange2.t ....... ok
t/apache/byterange3.t ....... skipped: (no reason given)
t/apache/byterange4.t ....... ok
t/apache/byterange5.t ....... ok
t/apache/byterange6.t ....... skipped: apache version 2.3.15 or higher
is required, this is version 2.0.65
t/apache/byterange7.t ....... ok

Thanks for putting this together so that there was something to try out!!!!

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by Rainer Jung <ra...@kippdata.de>.
On 01.09.2011 19:18, William A. Rowe Jr. wrote:
> On 9/1/2011 2:41 AM, "Plüm, Rüdiger, VF-Group" wrote:

> Ideally can you provide me the -verbose output (offlist or to your
> people.a.o/ space if it's lengthy)?

Sorry for kicking in late. I was on holidays until Sunday and was a bit
overwhelmed by what had happened in between.

I built 2.0 trunk with your patch on Solaris Sparc 32 Bits and a lot of
the byterange tests fail for me also.

I put the test output and the complete test directory for prefork and
worker at:

http://people.apache.org/~rjung/CVE-2011-3192/2.0.x/test/

The tarballs contain the error and access logs.

Regards,

Rainer

Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/1/2011 2:41 AM, "Plüm, Rüdiger, VF-Group" wrote:
>  
> 
>> -----Original Message-----
>> From: William A. Rowe Jr. [mailto:wrowe@rowe-clan.net] 
>> Sent: Donnerstag, 1. September 2011 03:51
>> To: dev@httpd.apache.org
>> Subject: Re: Appropriate patches for 2.2.19 and 2.0.64?
>>
>> On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
>>> I've attempted to simply substitute the 2.2.19 filter code into the
>>> 2.0.64 http_protocol.c sources, and am unsure how far off 
>> these patches
>>> are from what they need to be; there's been a significant 
>> amount of drift
>>> and refactoring in the interim.
>>
>> Still looking for feedback, but the attached applies and 
>> corresponds to
>> 2.2.20 with the exception of atoi rather than strtoi 
>> semantics, and without
>> the no DefaultType exception..
>>
>>
>>
> 
> Thanks for taking care. It applies cleanly, but most byterange tests
> from the framework fail:
> 
> Failed Test           Stat Wstat Total Fail  Failed  List of Failed
> -------------------------------------------------------------------------------
> t/apache/byterange.t               136   97  71.32%  2-9 11 16-17 19-20 25-26
>                                                      28 33-35 37-39 42 44-47
>                                                      49-61 63-68 70-73 77-79
>                                                      83-88 90-96 98-99 101-103
>                                                      105-113 115-123 126-127
>                                                      130 132-136
> t/apache/byterange5.t                5    4  80.00%  1 3-5
> t/apache/byterange7.t               13    5  38.46%  2-5 12
> 
> This might be because I use a 64 bit build of 2.0.x (no other test environment at hand
> at the moment) and 2.0.x is not really good at 64 bit (lots of compiler warnings).

Ideally can you provide me the -verbose output (offlist or to your
people.a.o/ space if it's lengthy)?



Re: Appropriate patches for 2.2.19 and 2.0.64?

Posted by dreamice <dr...@gmail.com>.
Is there anyone has tested the 2.2.19 with this patch?

2011/9/1 "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>

>
>
> > -----Original Message-----
> > From: William A. Rowe Jr. [mailto:wrowe@rowe-clan.net]
> > Sent: Donnerstag, 1. September 2011 03:51
> > To: dev@httpd.apache.org
> > Subject: Re: Appropriate patches for 2.2.19 and 2.0.64?
> >
> > On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
> > > I've attempted to simply substitute the 2.2.19 filter code into the
> > > 2.0.64 http_protocol.c sources, and am unsure how far off
> > these patches
> > > are from what they need to be; there's been a significant
> > amount of drift
> > > and refactoring in the interim.
> >
> > Still looking for feedback, but the attached applies and
> > corresponds to
> > 2.2.20 with the exception of atoi rather than strtoi
> > semantics, and without
> > the no DefaultType exception..
> >
> >
> >
>
> Thanks for taking care. It applies cleanly, but most byterange tests
> from the framework fail:
>
> Failed Test           Stat Wstat Total Fail  Failed  List of Failed
>
> -------------------------------------------------------------------------------
> t/apache/byterange.t               136   97  71.32%  2-9 11 16-17 19-20
> 25-26
>                                                     28 33-35 37-39 42 44-47
>                                                     49-61 63-68 70-73 77-79
>                                                     83-88 90-96 98-99
> 101-103
>                                                     105-113 115-123 126-127
>                                                     130 132-136
> t/apache/byterange5.t                5    4  80.00%  1 3-5
> t/apache/byterange7.t               13    5  38.46%  2-5 12
>
> This might be because I use a 64 bit build of 2.0.x (no other test
> environment at hand
> at the moment) and 2.0.x is not really good at 64 bit (lots of compiler
> warnings).
>
>
> Regards
>
> Rüdiger
>

RE: Appropriate patches for 2.2.19 and 2.0.64?

Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
 

> -----Original Message-----
> From: William A. Rowe Jr. [mailto:wrowe@rowe-clan.net] 
> Sent: Donnerstag, 1. September 2011 03:51
> To: dev@httpd.apache.org
> Subject: Re: Appropriate patches for 2.2.19 and 2.0.64?
> 
> On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
> > I've attempted to simply substitute the 2.2.19 filter code into the
> > 2.0.64 http_protocol.c sources, and am unsure how far off 
> these patches
> > are from what they need to be; there's been a significant 
> amount of drift
> > and refactoring in the interim.
> 
> Still looking for feedback, but the attached applies and 
> corresponds to
> 2.2.20 with the exception of atoi rather than strtoi 
> semantics, and without
> the no DefaultType exception..
> 
> 
> 

Thanks for taking care. It applies cleanly, but most byterange tests
from the framework fail:

Failed Test           Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/apache/byterange.t               136   97  71.32%  2-9 11 16-17 19-20 25-26
                                                     28 33-35 37-39 42 44-47
                                                     49-61 63-68 70-73 77-79
                                                     83-88 90-96 98-99 101-103
                                                     105-113 115-123 126-127
                                                     130 132-136
t/apache/byterange5.t                5    4  80.00%  1 3-5
t/apache/byterange7.t               13    5  38.46%  2-5 12

This might be because I use a 64 bit build of 2.0.x (no other test environment at hand
at the moment) and 2.0.x is not really good at 64 bit (lots of compiler warnings).


Regards

Rüdiger