You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhoulii (via GitHub)" <gi...@apache.org> on 2025/07/23 08:59:58 UTC

[PR] [core] Automatically detect changes to the expiration policy. [paimon]

zhoulii opened a new pull request, #5944:
URL: https://github.com/apache/paimon/pull/5944

   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #5943 
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on PR #5944:
URL: https://github.com/apache/paimon/pull/5944#issuecomment-3125860477

   Thanks for the review @JingsongLi . All comments have been addressed, Please take another look when you have a moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "mxdzs0612 (via GitHub)" <gi...@apache.org>.
mxdzs0612 commented on PR #5944:
URL: https://github.com/apache/paimon/pull/5944#issuecomment-3509133905

   Hi @zhoulii , is this PR still in progress? Or when will it be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #5944: [core] Automatically detect changes to the expiration policy.
URL: https://github.com/apache/paimon/pull/5944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5944:
URL: https://github.com/apache/paimon/pull/5944#issuecomment-4414038182

   This pull request has had no activity for 90 days. If you'd like to keep it open, please push a new commit or leave a comment. Thanks for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5944:
URL: https://github.com/apache/paimon/pull/5944#discussion_r2234761386


##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -443,6 +443,12 @@ public InlineElement getDescription() {
                     .withDescription(
                             "The maximum number of snapshots allowed to expire at a time.");
 
+    public static final ConfigOption<Boolean> DETECT_EXPIRATION_SETTING_ENABLED =
+            key("detect-expiration-setting.enabled")

Review Comment:
   `snapshot.expire.detect-config.enabled`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Automatically detect changes to the expiration policy. [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5944:
URL: https://github.com/apache/paimon/pull/5944#discussion_r2230789780


##########
paimon-core/src/main/java/org/apache/paimon/table/ExpireChangelogImpl.java:
##########
@@ -79,6 +87,12 @@ public ExpireSnapshots config(ExpireConfig expireConfig) {
 
     @Override
     public int expire() {
+        TableSchema latestTableSchema = this.schemaManager.latest().get();

Review Comment:
   This will bring additional IO access. Can you introduce a new option to describe whether a refresh is needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org