You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Matt Benson (JIRA)" <ji...@apache.org> on 2009/12/29 23:37:29 UTC

[jira] Resolved: (COLLECTIONS-255) Unused variable in TreeBidiMap.java

     [ https://issues.apache.org/jira/browse/COLLECTIONS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved COLLECTIONS-255.
-------------------------------------

    Resolution: Fixed

! /Users/mbenson/oss/asf/commons/trunks-proper/collections> svn commit -m "[COLLECTIONS-255] re-address unused cache variable in TreeBidiMap" src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java 
Sending        src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java
Transmitting file data .
Committed revision 894500.


> Unused variable in TreeBidiMap.java
> -----------------------------------
>
>                 Key: COLLECTIONS-255
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-255
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: BidiMap
>    Affects Versions: Nightly Builds
>            Reporter: Henri Yandell
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: COLLECTIONS-255.patch
>
>
> Twice in TreeBidiMap there is an entrySet variable that is not used. Rather the entrySet() method returns a new TreeView every time.
> We should either:
> a) Delete the variable.
> b) Use the variable and always return the same TreeView.
> I'm thinking a).
> [Found via http://opensource.fortifysoftware.com/ ]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.