You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/08/27 00:50:29 UTC

[GitHub] [submarine] wangdatan commented on pull request #382: SUBMARINE-558. Define Swagger API for pre-defined template submission

wangdatan commented on pull request #382:
URL: https://github.com/apache/submarine/pull/382#issuecomment-681198095


   Thanks @JohnTing for the patch, I reviewed registration flow, and what does the API looks like. I actually like the new implementation more than the original design of https://github.com/apache/submarine/blob/master/docs/design/experiment-implementation.md. The parameterized implementation is very clean and very easy for users to register and understand. Great job! 
   
   I will leave the detailed code review works to others, at a high-level, the implementation looks good! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org