[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r246921467
 
 

 ##########
 File path: libminifi/include/sitetosite/RawSocketProtocol.h
 ##########
 @@ -143,21 +140,21 @@ class RawSiteToSiteClient : public sitetosite::SiteToSiteClient {
   // tearDown
   virtual void tearDown();
   // write Request Type
-  virtual int writeRequestType(RequestType type);
+  virtual int writeRequestType(RequestType type) {
+    return SiteToSiteClient::writeRequestType(type);
 
 Review comment:
   I think the code being in SiteToSiteClient is vestigial. It probably shouldn't be there. That also would reduce the risk of any testing. Just remove it from the base class. The only other implementation ( and others I have in mind ) wouldn't need this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services