You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/10 22:34:48 UTC
Review Request 55394: Changed `Master::updateTask` to allow terminal
tasks to be updated.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55394/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Changed `Master::updateTask` to allow terminal tasks to be updated.
Diffs
-----
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/55394/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55394: Changed `Master::updateTask` to allow
terminal tasks to be updated.
Posted by Neil Conway <ne...@gmail.com>.
> On Jan. 10, 2017, 11:51 p.m., Vinod Kone wrote:
> > What's the motivation for this change?
This is needed by https://reviews.apache.org/r/54232/ -- if we're going to update the task from `UNREACHABLE` to `KILLED`, we need `updateTask()` to be able to transition a task from one "terminal" state to another. (As a separate matter, we should remove TASK_UNREACHABLE from the list of states in `isTerminalState()`, but that should probably be done separately.)
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55394/#review161145
-----------------------------------------------------------
On Jan. 10, 2017, 10:34 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55394/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 10:34 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed `Master::updateTask` to allow terminal tasks to be updated.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
>
> Diff: https://reviews.apache.org/r/55394/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55394: Changed `Master::updateTask` to allow
terminal tasks to be updated.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55394/#review161145
-----------------------------------------------------------
What's the motivation for this change?
- Vinod Kone
On Jan. 10, 2017, 10:34 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55394/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 10:34 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed `Master::updateTask` to allow terminal tasks to be updated.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
>
> Diff: https://reviews.apache.org/r/55394/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>