You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lucky-chen <gi...@git.apache.org> on 2018/05/15 07:36:13 UTC

[GitHub] incubator-weex pull request #1176: [WEEX-364][iOS] support swift build

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1176

    [WEEX-364][iOS] support swift build

    fix c++/OC/swift  build issue
    
    1. add  define ```_cplusplus```   with c++    .h
    2. use ```std::isnan``` to replace `isnan`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex ios_support_swift

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1176
    
----
commit 4708a9413e4c8f589528a6c123dc9f7031009e21
Author: zouming.zm <zo...@...>
Date:   2018-05-15T04:02:03Z

    hide some prop in .h file
    
    * [iOS] head newlayout node.h
    
    * [iOS] fix compile error

----


---

[GitHub] incubator-weex pull request #1176: [WEEX-364][iOS] support swift build

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1176


---

[GitHub] incubator-weex issue #1176: [WEEX-364][iOS] support swift build

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1176
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no android file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>android test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---