[GitHub] sxjscience opened a new pull request #9148: add warning for the Block inside list pattern

[GitBox <gi...@apache.org>]

sxjscience opened a new pull request #9148: add warning for the Block inside list pattern
URL: https://github.com/apache/incubator-mxnet/pull/9148
 
 
   Since we do not automatically register the Blocks inside a list/dict, the code will have bugs if the user tries to insert class attributes like `self.layers = [Block, Block, ...]` or `self.layers = {'a': Block, 'b': Block}`.
   
   Now, we warn the users when we find such a behavior and recommend them to register the Blocks manually or use `nn.Sequential` instead.
   
   ## Description ##
   Raise warnings when we detect the pattern: Block under nested list/dict
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Add warning, tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services