You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/12 01:58:50 UTC

[GitHub] [incubator-superset] ktmud opened a new pull request #10850: feat: server side dashboard css for less repaint

ktmud opened a new pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850


   ### SUMMARY
   
   Add custom dashboard css to server side rendering so the page doesn't have to repaint when refresh.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   Since custom CSS is added after dashboard is loaded, when loading a dashboard, you may see an annoying repaint:
   
   ![load-repaint](https://user-images.githubusercontent.com/335541/92984619-55199880-f460-11ea-89cd-fd79fd57c1f7.gif)
   
   #### After
   
   No repaint when refreshing the page:
   
   ![no-repaint](https://user-images.githubusercontent.com/335541/92984648-85f9cd80-f460-11ea-9b2c-e93f3cd10eb3.gif)
   
   
   ### TEST PLAN
   
   Manual testing.
   
   1. Go add some custom CSS to a dashboard. Following is used in the screenshots:
      ```css
      body {
        font-family: monospace;
      }
      #app-menu {
        display: none;
      }
      ```
   2. Save and refresh the page.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487353586



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487354166



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487353586



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487354166



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487353586



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud merged pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=h1) Report
   > Merging [#10850](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7cd96edcdf66c4f5ee6c1d5eb75987e5ddda03cc?el=desc) will **decrease** coverage by `3.87%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10850/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10850      +/-   ##
   ==========================================
   - Coverage   65.46%   61.59%   -3.88%     
   ==========================================
     Files         809      429     -380     
     Lines       38154    14084   -24070     
     Branches     3605     3605              
   ==========================================
   - Hits        24979     8675   -16304     
   + Misses      13066     5223    -7843     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (ø)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [533 more](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=footer). Last update [7cd96ed...a2b55f5](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=h1) Report
   > Merging [#10850](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7cd96edcdf66c4f5ee6c1d5eb75987e5ddda03cc?el=desc) will **decrease** coverage by `4.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10850/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10850      +/-   ##
   ==========================================
   - Coverage   65.46%   60.77%   -4.70%     
   ==========================================
     Files         809      809              
     Lines       38154    38141      -13     
     Branches     3605     3605              
   ==========================================
   - Hits        24979    23181    -1798     
   - Misses      13066    14774    +1708     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (ø)` | |
   | #python | `60.29% <ø> (-1.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <ø> (-0.25%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=footer). Last update [7cd96ed...a2b55f5](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=h1) Report
   > Merging [#10850](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7cd96edcdf66c4f5ee6c1d5eb75987e5ddda03cc?el=desc) will **decrease** coverage by `3.87%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10850/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10850      +/-   ##
   ==========================================
   - Coverage   65.46%   61.59%   -3.88%     
   ==========================================
     Files         809      429     -380     
     Lines       38154    14084   -24070     
     Branches     3605     3605              
   ==========================================
   - Hits        24979     8675   -16304     
   + Misses      13066     5223    -7843     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (ø)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [533 more](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=footer). Last update [7cd96ed...a2b55f5](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=h1) Report
   > Merging [#10850](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7cd96edcdf66c4f5ee6c1d5eb75987e5ddda03cc?el=desc) will **decrease** coverage by `4.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10850/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10850      +/-   ##
   ==========================================
   - Coverage   65.46%   60.98%   -4.49%     
   ==========================================
     Files         809      809              
     Lines       38154    38152       -2     
     Branches     3605     3605              
   ==========================================
   - Hits        24979    23266    -1713     
   - Misses      13066    14700    +1634     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (ø)` | |
   | #python | `60.62% <ø> (-0.72%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <ø> (-0.25%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=footer). Last update [7cd96ed...a2b55f5](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#issuecomment-691382234


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=h1) Report
   > Merging [#10850](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7cd96edcdf66c4f5ee6c1d5eb75987e5ddda03cc?el=desc) will **decrease** coverage by `3.87%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10850/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10850      +/-   ##
   ==========================================
   - Coverage   65.46%   61.59%   -3.88%     
   ==========================================
     Files         809      429     -380     
     Lines       38154    14084   -24070     
     Branches     3605     3605              
   ==========================================
   - Hits        24979     8675   -16304     
   + Misses      13066     5223    -7843     
   - Partials      109      186      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <ø> (ø)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [533 more](https://codecov.io/gh/apache/incubator-superset/pull/10850/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=footer). Last update [7cd96ed...a2b55f5](https://codecov.io/gh/apache/incubator-superset/pull/10850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487354166



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10850: feat: server side dashboard css for less repaint

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487353586



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,13 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style type="text/css">{{ custom_css }}</style>

Review comment:
       ```suggestion
       <style type="text/css">{{ custom_css }}</style>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org