[jira] [Commented] (HBASE-14796) Enhance the Gets in the connector

["Ted Malaska (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070177#comment-15070177 ] 

Ted Malaska commented on HBASE-14796:
-------------------------------------

I reviewed the code and I'm giving it a +1

Did you do the performance tests?  As long as we are not going slower I'm good here.

The test should be done on a cluster not in local mode.  It can be done on warmed Yarn containers, we don't need to count the time to start Yarn.

I would like to se what the different in time is when running the following tests:
1. a select statement with a single get
2. a select statement with a 10 get
3. a select statement with a 1000 get

Maybe also we should test with different row sizes.  
1. 300bits
2. 3Kb
3. 30KB

Let me know what you think.

Thanks again Zhan

> Enhance the Gets in the connector
> ---------------------------------
>
>                 Key: HBASE-14796
>                 URL: https://issues.apache.org/jira/browse/HBASE-14796
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Malaska
>            Assignee: Zhan Zhang
>            Priority: Minor
>         Attachments: HBASE-14976.patch
>
>
> Current the Spark-Module Spark SQL implementation gets records from HBase from the driver if there is something like the following found in the SQL.
> rowkey = 123
> The reason for this original was normal sql will not have many equal operations in a single where clause.
> Zhan, had brought up too points that have value.
> 1. The SQL may be generated and may have many many equal statements in it so moving the work to an executor protects the driver from load
> 2. In the correct implementation the drive is connecting to HBase and exceptions may cause trouble with the Spark application and not just with the a single task execution



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)