You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2023/02/03 08:17:47 UTC

[kyuubi] branch master updated: [KYUUBI #3658][FOLLOWUP] Show ssl enabled protocols

This is an automated email from the ASF dual-hosted git repository.

feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 265aaf285 [KYUUBI #3658][FOLLOWUP] Show ssl enabled protocols
265aaf285 is described below

commit 265aaf28543a659e6590bc1ecc86c7f2f53fba50
Author: fwang12 <fw...@ebay.com>
AuthorDate: Fri Feb 3 16:17:39 2023 +0800

    [KYUUBI #3658][FOLLOWUP] Show ssl enabled protocols
    
    ### _Why are the changes needed?_
    
    Before:
    ```
    2023-02-02 22:21:35.507 INFO org.apache.kyuubi.server.KyuubiTBinaryFrontendService: SSL Server Socket enabled protocols: [Ljava.lang.String;2fca3eb5
    ```
    
    Seems `enabledProtocols` is a java array, the output is not friendly.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4238 from turboFei/ssl_followup.
    
    Closes #3658
    
    999ef90e6 [fwang12] Show enabled ssl protocols
    
    Authored-by: fwang12 <fw...@ebay.com>
    Signed-off-by: fwang12 <fw...@ebay.com>
---
 .../main/scala/org/apache/kyuubi/service/TBinaryFrontendService.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/TBinaryFrontendService.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/TBinaryFrontendService.scala
index 74cf4e2e6..2e8a8b765 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/TBinaryFrontendService.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/TBinaryFrontendService.scala
@@ -163,7 +163,7 @@ abstract class TBinaryFrontendService(name: String)
           }
         }
         sslServerSocket.setEnabledProtocols(enabledProtocols)
-        info(s"SSL Server Socket enabled protocols: $enabledProtocols")
+        info(s"SSL Server Socket enabled protocols: ${enabledProtocols.mkString(",")}")
 
       case _ =>
     }