You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by Konrad Windszus <ko...@gmx.de> on 2016/11/02 10:25:30 UTC

Sling Eclipse IDE Release?

Unfortunately the current version of Sling Eclipse IDE is not compatible with the newest maven-bundle-plugin 3.2.0 with the new m2e lifecycle mapping for the manifest goal (set up like described in http://felix.apache.org/documentation/faqs/apache-felix-bundle-plugin-faq.html#use-scr-metadata-generated-by-bnd-in-unit-tests). I fixed that with https://issues.apache.org/jira/browse/SLING-6112 by making m2e-tycho no longer a requirement. 

Apart from that 11 other issues have been resolved (https://issues.apache.org/jira/browse/SLING-5634?jql=project%20%3D%20SLING%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20ORDER%20BY%20priority%20DESC).

I would therefore like to have a new release from Sling IDE within the next weeks.
Is there anything important missing from the unresolved issues supposably fixed with Sling Eclipse IDE 1.1.2 (https://issues.apache.org/jira/browse/SLING-4455?jql=fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20AND%20project%20%3D%20SLING%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC)?

Konrad

Re: Sling Eclipse IDE Release?

Posted by Konrad Windszus <ko...@gmx.de>.

Hi Robert

> Am 02.11.2016 um 14:34 schrieb Robert Munteanu <ro...@apache.org>:
> 
> Hi Konrad,
> 
>> On Wed, 2016-11-02 at 11:25 +0100, Konrad Windszus wrote:
>> Unfortunately the current version of Sling Eclipse IDE is not
>> compatible with the newest maven-bundle-plugin 3.2.0 with the new m2e
>> lifecycle mapping for the manifest goal (set up like described in
>> http://felix.apache.org/documentation/faqs/apache-felix-bundle-
>> plugin-faq.html#use-scr-metadata-generated-by-bnd-in-unit-tests). I
>> fixed that with https://issues.apache.org/jira/browse/SLING-6112 by
>> making m2e-tycho no longer a requirement. 
> 
> I would suggest making this 1.2.0 . With the contributions that you
> made it's definitely not a bugfix release :-)
> 
Ok, let's call it 1.2.0. I will adjust in JIRA tomorrow.
>> 
>> Apart from that 11 other issues have been resolved (https://issues.ap
>> ache.org/jira/browse/SLING-
>> 5634?jql=project%20%3D%20SLING%20AND%20status%20%3D%20Resolved%20AND%
>> 20fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20ORDER%20BY
>> %20priority%20DESC).
>> 
>> I would therefore like to have a new release from Sling IDE within
>> the next weeks.
>> Is there anything important missing from the unresolved issues
>> supposably fixed with Sling Eclipse IDE 1.1.2 (https://issues.apache.
>> org/jira/browse/SLING-
>> 4455?jql=fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20AND
>> %20project%20%3D%20SLING%20AND%20resolution%20%3D%20Unresolved%20ORDE
>> R%20BY%20priority%20DESC)?
> 
> I just filed
> 
> https://issues.apache.org/jira/browse/SLING-6231
> 
> regarding the unstable Sightly editor tests. Not sure if I will manage
> to fix them, but it would be good to.
> 
> I am also writing some tests for 
> 
>  https://issues.apache.org/jira/browse/SLING-6112
> 
> to make sure the proper markers are attached.
> 
Great, thanks a lot.
> Other than that, I have an upstream bug report from the AEM Developer
> Tools
> 
>  https://github.com/Adobe-Marketing-Cloud/aem-eclipse-developer-tools/
> issues/72
> 
> which is probably related to code in the Sling IDE Tooling, but I have
> not yet managed to reproduce it :-( If you have seen this or have more
> information about how this could be reproduced I'd really like this
> fixed for the next release.

I have seen this issue only once, but did not yet find a reliable way to reproduce it. Also I have seen one other issue were hiding the servlet descriptor entry point in the package explorer was not hidden. Have not yet found a way to reproduce either. Will look into both issues tomorrow. 

One last thing is around xml validation. Seems that this is fully disabled for sling-content facet. what was the reason to disable that and where in the code does that happen. I would like to have that validator rather enabled and just disable the warning related to the missing schema. Can you give a hint on that one?
> 
> Thanks,
> 
> Robert

Re: Sling Eclipse IDE Release?

Posted by Robert Munteanu <ro...@apache.org>.

Hi Konrad,

On Wed, 2016-11-02 at 11:25 +0100, Konrad Windszus wrote:
> Unfortunately the current version of Sling Eclipse IDE is not
> compatible with the newest maven-bundle-plugin 3.2.0 with the new m2e
> lifecycle mapping for the manifest goal (set up like described in
> http://felix.apache.org/documentation/faqs/apache-felix-bundle-
> plugin-faq.html#use-scr-metadata-generated-by-bnd-in-unit-tests). I
> fixed that with https://issues.apache.org/jira/browse/SLING-6112 by
> making m2e-tycho no longer a requirement.�

I would suggest making this 1.2.0 . With the contributions that you
made it's definitely not a bugfix release :-)

> 
> Apart from that 11 other issues have been resolved (https://issues.ap
> ache.org/jira/browse/SLING-
> 5634?jql=project%20%3D%20SLING%20AND%20status%20%3D%20Resolved%20AND%
> 20fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20ORDER%20BY
> %20priority%20DESC).
> 
> I would therefore like to have a new release from Sling IDE within
> the next weeks.
> Is there anything important missing from the unresolved issues
> supposably fixed with Sling Eclipse IDE 1.1.2 (https://issues.apache.
> org/jira/browse/SLING-
> 4455?jql=fixVersion%20%3D%20%22Sling%20Eclipse%20IDE%201.1.2%22%20AND
> %20project%20%3D%20SLING%20AND%20resolution%20%3D%20Unresolved%20ORDE
> R%20BY%20priority%20DESC)?

I just filed

 https://issues.apache.org/jira/browse/SLING-6231

regarding the unstable Sightly editor tests. Not sure if I will manage
to fix them, but it would be good to.

I am also writing some tests for 

  https://issues.apache.org/jira/browse/SLING-6112

to make sure the proper markers are attached.

Other than that, I have an upstream bug report from the AEM Developer
Tools

  https://github.com/Adobe-Marketing-Cloud/aem-eclipse-developer-tools/
issues/72

which is probably related to code in the Sling IDE Tooling, but I have
not yet managed to reproduce it :-( If you have seen this or have more
information about how this could be reproduced I'd really like this
fixed for the next release.

Thanks,

Robert