You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/01/07 17:36:08 UTC
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16931
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
These tests were disabled due to S3's eventually consistent
behavior. Now that S3 is strongly consistent, these tests do
not need to be disabled.
Testing:
- Ran s3 core job
Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
---
M tests/common/skip.py
M tests/metadata/test_compute_stats.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
7 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16931/1
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16931 )
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
These tests were disabled due to S3's eventually consistent
behavior. Now that S3 is strongly consistent, these tests do
not need to be disabled.
Testing:
- Ran s3 core job
Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Reviewed-on: http://gerrit.cloudera.org:8080/16931
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/metadata/test_compute_stats.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_nested_types.py
7 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16931 )
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6831/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 18:10:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16931 )
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
Patch Set 1: Code-Review+2
Thanks for cleaning up
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 18:09:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16931 )
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:48:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10427: Remove SkipIfS3.eventually consistent pytest marker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16931 )
Change subject: IMPALA-10427: Remove SkipIfS3.eventually_consistent pytest marker
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7970/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9041f530bf3a818f8954b31a3d01d9f6753d7d4
Gerrit-Change-Number: 16931
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:57:47 +0000
Gerrit-HasComments: No