[PR] fix runtime pm pm_wakelock_uninit problem, decrease charger log, regulator possible no action when boot [nuttx]

["jasonbu (via GitHub)" <gi...@apache.org>]

jasonbu opened a new pull request, #14001:
URL: https://github.com/apache/nuttx/pull/14001

   ## Summary
   fix runtime pm pm_wakelock_uninit problem
   decrease charger log
   regulator possible no action when boot
   
   ## Impact
   bugfix,
   possible decrease charger log.
   
   ## Testing
   CI-test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix runtime pm pm_wakelock_uninit problem, decrease charger log, regulator possible no action when boot [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14001:
URL: https://github.com/apache/nuttx/pull/14001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix runtime pm pm_wakelock_uninit problem, decrease charger log, regulator possible no action when boot [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14001:
URL: https://github.com/apache/nuttx/pull/14001#issuecomment-2402222237

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX requirements.** 
   
   Here's why and how to improve it:
   
   * **Summary:**
       * **Insufficient detail:** The summary uses vague terms like "problem" and "possible decrease." Be specific about the issue the PR addresses. 
           * **Example:** "Fixes a bug where pm_wakelock_uninit could lead to [describe the specific issue, e.g., system hang, resource leak]. Also reduces verbose logging related to the charger driver."
       * **Missing context:**  Explain what functional areas are impacted (e.g., power management, logging, regulator framework).
       * **No links:** Include links to relevant NuttX issues or pull requests if they exist.
   
   * **Impact:**
       * **Too brief:** Provide more information in the "YES" sections.
           * **Example:**  
               * "Impact on build: YES - The charger driver now produces fewer log messages by default. This may require users who rely on these logs to adjust their debugging configurations."
               * "Impact on hardware: YES -  This PR addresses a potential issue where regulators might not be properly initialized during boot on certain boards. Please list the specific boards or architectures affected."
       * **Unclear on user impact:** Will users need to make any changes to their configurations or applications due to this fix? Be explicit.
   
   * **Testing:**
       * **Insufficient information:**
           * **Specify build host:** List the operating system, CPU architecture, and compiler used for testing.
           * **Specify target(s):** State the architecture(s) and board configurations tested on (both real hardware and simulators if applicable).
       * **Missing logs:** Provide relevant "before" and "after" log snippets that clearly demonstrate the problem and the fix. Highlight the key changes in the logs.
   
   **To improve your PR:**
   
   1. **Expand on each section** using the feedback above.
   2. **Follow the PR template closely.**
   3. **Provide specific and detailed information.**  The goal is to give reviewers a clear understanding of your changes and their impact. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org