You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by bo...@apache.org on 2010/09/17 19:10:31 UTC

svn commit: r998209 - in /buildr/trunk: CHANGELOG lib/buildr/packaging/gems.rb

Author: boisvert
Date: Fri Sep 17 17:10:30 2010
New Revision: 998209

URL: http://svn.apache.org/viewvc?rev=998209&view=rev
Log:
BUILDR-506 Gem packaging does not work under windows (Peter Donald)

Modified:
    buildr/trunk/CHANGELOG
    buildr/trunk/lib/buildr/packaging/gems.rb

Modified: buildr/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/buildr/trunk/CHANGELOG?rev=998209&r1=998208&r2=998209&view=diff
==============================================================================
--- buildr/trunk/CHANGELOG (original)
+++ buildr/trunk/CHANGELOG Fri Sep 17 17:10:30 2010
@@ -40,6 +40,7 @@
           e.g. (Java.java.lang.String cached as Java::Lang::String) 
           can shadow Ruby modules
 * Fixed:  BUILDR-501 Fix buildr label when listing tasks (Peter Donald)
+* Fixed:  BUILDR-506 Gem packaging does not work under windows (Peter Donald)
 * Fixed:  BUILDR-508 Remove unnecessary use of Java.classpath in OpenJPA
           extension (Peter Donald)
 

Modified: buildr/trunk/lib/buildr/packaging/gems.rb
URL: http://svn.apache.org/viewvc/buildr/trunk/lib/buildr/packaging/gems.rb?rev=998209&r1=998208&r2=998209&view=diff
==============================================================================
--- buildr/trunk/lib/buildr/packaging/gems.rb (original)
+++ buildr/trunk/lib/buildr/packaging/gems.rb Fri Sep 17 17:10:30 2010
@@ -60,11 +60,10 @@ module Buildr
       spec.mark_version
       spec.validate
 
-      File.open(name, 'w') do |io|
+      File.open(name, 'wb') do |io|
         Gem::Package.open(io, 'w', nil) do |pkg|
           pkg.metadata = spec.to_yaml
           file_map.each do |path, content|
-            p "path #{path} content #{content}"
             next if content.nil? || File.directory?(content.to_s)
             pkg.add_file_simple(path, File.stat(content.to_s).mode & 0777, File.size(content.to_s)) do |os|
               File.open(content.to_s, "rb") do |file|