You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/25 15:24:36 UTC

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5513: [TOPI]][RELAY][MXNET]Reverse/Flip operator

tqchen commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-tvm/pull/5513#discussion_r460415078



##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -174,10 +174,11 @@ struct TileAttrs : public tvm::AttrsNode<TileAttrs> {
 
 /*! \brief Attributes used in reverse operators */
 struct ReverseAttrs : public tvm::AttrsNode<ReverseAttrs> {
-  Integer axis;
+  Array<Integer> axes;

Review comment:
       NOTE, as per https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures we shoud always be consistent with numpy API. As a result, let us use the name axis instead. See also https://github.com/apache/incubator-tvm/blob/master/include/tvm/relay/attrs/reduce.h#L36




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org