You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/02/21 09:10:38 UTC
[PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Gabriel39 opened a new pull request, #31216:
URL: https://github.com/apache/doris/pull/31216
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956197239
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31216:
URL: https://github.com/apache/doris/pull/31216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956315711
<details>
<summary>TPC-H: <b>Total hot run time: 41420 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 756ccfa3562d1366eea314433d11917157e00344, data reload: false
------ Round 1 ----------------------------------
q1 17651 4988 4850 4850
q2 2030 146 132 132
q3 10580 1001 991 991
q4 4647 962 972 962
q5 7702 3188 3252 3188
q6 197 134 134 134
q7 1256 772 763 763
q8 9246 2068 2059 2059
q9 7560 6688 6696 6688
q10 8317 2634 2632 2632
q11 415 227 223 223
q12 724 326 325 325
q13 17975 3700 3680 3680
q14 291 259 258 258
q15 586 511 508 508
q16 474 409 420 409
q17 912 866 846 846
q18 7423 6667 6641 6641
q19 1522 1483 1493 1483
q20 633 357 338 338
q21 6950 4021 3984 3984
q22 862 345 326 326
Total cold run time: 107953 ms
Total hot run time: 41420 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4887 4816 4836 4816
q2 290 180 184 180
q3 3604 3569 3590 3569
q4 2533 2556 2540 2540
q5 5764 5753 5783 5753
q6 205 130 129 129
q7 2231 1675 1665 1665
q8 3053 3114 3124 3114
q9 8735 8758 8694 8694
q10 6776 4240 4233 4233
q11 521 377 355 355
q12 762 533 552 533
q13 4646 3402 3418 3402
q14 263 246 252 246
q15 597 541 509 509
q16 505 425 450 425
q17 1675 1614 1627 1614
q18 8222 7614 7541 7541
q19 1636 1624 1622 1622
q20 2124 1813 1814 1813
q21 6587 6195 6168 6168
q22 559 491 498 491
Total cold run time: 66175 ms
Total hot run time: 59412 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956202028
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956302891
TeamCity be ut coverage result:
Function Coverage: 35.80% (8556/23900)
Line Coverage: 27.61% (69440/251472)
Region Coverage: 26.75% (36030/134696)
Branch Coverage: 23.55% (18428/78234)
Coverage Report: http://coverage.selectdb-in.cc/coverage/756ccfa3562d1366eea314433d11917157e00344_756ccfa3562d1366eea314433d11917157e00344/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956265907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956378249
TeamCity be ut coverage result:
Function Coverage: 35.79% (8554/23900)
Line Coverage: 27.60% (69412/251471)
Region Coverage: 26.74% (36011/134696)
Branch Coverage: 23.54% (18415/78234)
Coverage Report: http://coverage.selectdb-in.cc/coverage/affa66a1aa889163c7b737cf6ef1a8f71cbff708_affa66a1aa889163c7b737cf6ef1a8f71cbff708/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #31216:
URL: https://github.com/apache/doris/pull/31216#discussion_r1497170141
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -137,7 +134,28 @@ class Dependency : public std::enable_shared_from_this<Dependency> {
}
// Notify downstream pipeline tasks this dependency is blocked.
- virtual void block() { _ready = false; }
+ void block() {
Review Comment:
warning: method 'block' can be made static [readability-convert-member-functions-to-static]
```suggestion
static void block() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956431911
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956318075
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956392292
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit affa66a1aa889163c7b737cf6ef1a8f71cbff708 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956357945
<details>
<summary>TPC-H: <b>Total hot run time: 41577 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit affa66a1aa889163c7b737cf6ef1a8f71cbff708, data reload: false
------ Round 1 ----------------------------------
q1 17590 5036 4887 4887
q2 2049 145 135 135
q3 10568 1012 1000 1000
q4 4705 969 989 969
q5 7703 3246 3295 3246
q6 197 134 132 132
q7 1270 787 768 768
q8 9372 2104 2083 2083
q9 7739 6705 6702 6702
q10 8381 2646 2649 2646
q11 427 221 217 217
q12 742 331 333 331
q13 17993 3656 3676 3656
q14 294 253 260 253
q15 630 509 543 509
q16 517 421 413 413
q17 942 868 852 852
q18 7280 6722 6640 6640
q19 1532 1488 1495 1488
q20 583 366 344 344
q21 6292 4039 3985 3985
q22 872 344 321 321
Total cold run time: 107678 ms
Total hot run time: 41577 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4871 4891 4840 4840
q2 294 190 186 186
q3 3610 3604 3595 3595
q4 2562 2550 2538 2538
q5 5777 5771 5772 5771
q6 215 130 126 126
q7 2257 1667 1657 1657
q8 3071 3128 3151 3128
q9 8800 8765 8712 8712
q10 6915 4236 4235 4235
q11 527 386 359 359
q12 787 542 546 542
q13 4155 3399 3435 3399
q14 272 233 242 233
q15 630 505 507 505
q16 491 420 455 420
q17 1687 1646 1645 1645
q18 8333 7704 7593 7593
q19 1628 1640 1633 1633
q20 2120 1831 1822 1822
q21 6612 6211 6194 6194
q22 548 508 512 508
Total cold run time: 66162 ms
Total hot run time: 59641 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956431972
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956377617
<details>
<summary>TPC-DS: <b>Total hot run time: 177138 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit affa66a1aa889163c7b737cf6ef1a8f71cbff708, data reload: false
query1 926 353 343 343
query2 6500 1866 1950 1866
query3 6700 209 205 205
query4 23079 21145 21295 21145
query5 4313 382 369 369
query6 259 184 169 169
query7 4618 300 295 295
query8 250 202 208 202
query9 8408 2860 2857 2857
query10 415 235 217 217
query11 15091 14554 14441 14441
query12 145 81 83 81
query13 1695 417 422 417
query14 9753 7662 7712 7662
query15 220 185 183 183
query16 7616 266 256 256
query17 1377 565 537 537
query18 1952 263 261 261
query19 187 154 148 148
query20 86 78 80 78
query21 191 119 120 119
query22 4798 4792 4831 4792
query23 32520 31520 31467 31467
query24 12712 3391 3358 3358
query25 646 378 357 357
query26 1862 156 170 156
query27 3030 315 313 313
query28 6654 1851 1835 1835
query29 1124 605 602 602
query30 273 143 143 143
query31 951 744 758 744
query32 90 60 53 53
query33 719 232 243 232
query34 1059 499 504 499
query35 951 816 819 816
query36 1040 892 941 892
query37 170 60 63 60
query38 3345 3203 3206 3203
query39 1368 1321 1318 1318
query40 280 108 110 108
query41 36 35 35 35
query42 99 99 100 99
query43 470 461 465 461
query44 1064 692 711 692
query45 200 180 181 180
query46 1046 771 756 756
query47 1654 1565 1609 1565
query48 430 343 361 343
query49 1216 310 301 301
query50 764 371 370 370
query51 4433 4272 4283 4272
query52 115 94 93 93
query53 389 294 301 294
query54 290 216 216 216
query55 84 79 76 76
query56 217 200 195 195
query57 1065 933 988 933
query58 219 194 200 194
query59 2325 2225 2202 2202
query60 249 214 214 214
query61 81 80 86 80
query62 580 384 373 373
query63 344 289 287 287
query64 6233 3064 3112 3064
query65 3293 3258 3246 3246
query66 1344 328 321 321
query67 14791 14594 14210 14210
query68 5044 553 581 553
query69 519 356 358 356
query70 1245 1181 1267 1181
query71 407 251 255 251
query72 6357 2750 2612 2612
query73 701 318 314 314
query74 6854 6601 6500 6500
query75 3217 2564 2566 2564
query76 3206 1129 1212 1129
query77 352 247 236 236
query78 9333 8783 8769 8769
query79 977 512 512 512
query80 614 350 335 335
query81 435 201 201 201
query82 744 90 89 89
query83 237 120 123 120
query84 229 77 78 77
query85 1084 347 345 345
query86 298 300 314 300
query87 3477 3314 3318 3314
query88 2720 2291 2307 2291
query89 437 366 360 360
query90 2037 169 164 164
query91 152 126 131 126
query92 55 49 52 49
query93 1019 511 500 500
query94 1116 178 182 178
query95 482 391 384 384
query96 570 267 260 260
query97 4455 4276 4259 4259
query98 223 207 201 201
query99 1058 737 757 737
Total cold run time: 270058 ms
Total hot run time: 177138 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [pipelineX](refactor) Delete subclasses inherited from Dependency [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31216:
URL: https://github.com/apache/doris/pull/31216#issuecomment-1956387059
<details>
<summary>ClickBench: <b>Total hot run time: 31.79 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit affa66a1aa889163c7b737cf6ef1a8f71cbff708, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.02 0.02
query3 0.22 0.08 0.08
query4 1.64 0.11 0.09
query5 0.48 0.46 0.48
query6 1.38 0.62 0.61
query7 0.01 0.02 0.01
query8 0.03 0.03 0.02
query9 0.54 0.48 0.45
query10 0.48 0.50 0.49
query11 0.12 0.10 0.10
query12 0.13 0.10 0.09
query13 0.59 0.59 0.59
query14 0.76 0.78 0.80
query15 0.82 0.80 0.81
query16 0.33 0.33 0.33
query17 0.87 0.91 0.92
query18 0.18 0.18 0.18
query19 1.80 1.71 1.69
query20 0.02 0.02 0.01
query21 15.40 0.68 0.59
query22 3.24 4.61 3.13
query23 17.59 1.04 0.92
query24 1.99 0.46 0.56
query25 0.63 0.07 0.06
query26 0.15 0.14 0.14
query27 0.06 0.04 0.05
query28 11.96 0.85 0.84
query29 12.57 3.26 3.27
query30 0.54 0.49 0.49
query31 2.78 0.36 0.39
query32 3.31 0.49 0.48
query33 3.08 3.15 3.12
query34 15.36 4.51 4.50
query35 4.49 4.47 4.45
query36 1.09 0.94 0.96
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.02
query40 0.16 0.15 0.15
query41 0.07 0.01 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 105.12 s
Total hot run time: 31.79 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org