[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #6759: [Fix-6707][common] Fix complement data error because of global variables

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #6759:
URL: https://github.com/apache/dolphinscheduler/pull/6759#discussion_r745490522



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java
##########
@@ -99,8 +99,11 @@ public static String curingGlobalParams(Map<String, String> globalParamMap, List
         }
         Map<String, String> allParamMap = new HashMap<>();
         //If it is a complement, a complement time needs to be passed in, according to the task type
-        Map<String, String> timeParams = BusinessTimeUtils
-            .getBusinessTime(commandType, scheduleTime);
+        Map<String, String> timeParams = null;
+
+        if (scheduleTime != null) {
+            timeParams = BusinessTimeUtils.getBusinessTime(commandType, scheduleTime);

Review comment:
       It will effect other commandType, because BusinessTimeUtils.getBusinessTime allow scheduleTime is null to other commandType except COMPLEMENT_DATA




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org