You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ra...@apache.org on 2008/12/23 07:16:55 UTC

svn commit: r728881 - in /commons/proper/digester/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/digester/Digester.java

Author: rahul
Date: Mon Dec 22 22:16:55 2008
New Revision: 728881

URL: http://svn.apache.org/viewvc?rev=728881&view=rev
Log:
Potential NPE when debug is enabled
DIGESTER-122

Modified:
    commons/proper/digester/trunk/RELEASE-NOTES.txt
    commons/proper/digester/trunk/src/java/org/apache/commons/digester/Digester.java

Modified: commons/proper/digester/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/RELEASE-NOTES.txt?rev=728881&r1=728880&r2=728881&view=diff
==============================================================================
--- commons/proper/digester/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/digester/trunk/RELEASE-NOTES.txt Mon Dec 22 22:16:55 2008
@@ -53,6 +53,9 @@
  * [DIGESTER-111] Null arguments to all Digester#parse() methods now an
                   IllegalArgumentException.
 
+ * [DIGESTER-122] Potential NullPointerException if debug is enabled in
+                  Digester#resolveEntity()
+
 DEPRECATIONS
 ============
 None

Modified: commons/proper/digester/trunk/src/java/org/apache/commons/digester/Digester.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/java/org/apache/commons/digester/Digester.java?rev=728881&r1=728880&r2=728881&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/java/org/apache/commons/digester/Digester.java (original)
+++ commons/proper/digester/trunk/src/java/org/apache/commons/digester/Digester.java Mon Dec 22 22:16:55 2008
@@ -1599,7 +1599,7 @@
             if (systemId == null) {
                 // cannot resolve
                 if (log.isDebugEnabled()) {
-                    log.debug(" Cannot resolve entity: '" + entityURL + "'");
+                    log.debug(" Cannot resolve null entity, returning null InputSource");
                 }
                 return (null);