[GitHub] jena issue #236: No stacktrace on regex errors. Cancel/close during sorting.

[ehedgehog <gi...@git.apache.org>]

Github user ehedgehog commented on the issue:

    https://github.com/apache/jena/pull/236
  
    Whoops, clicked too soon. 
    
    In E_Regex.eval, we Log.warn(this,message). I see that using Log.warn would be
    inappropriate, since it acts globally and would switch off all logging of whatever
    we chose as a key, but as per the original problem it would be useful to
    suppress identical log lines.
    
    I wondered about replacing the Log.warn with
    
    String m = ex.getMessage();
                	if (!m.equals(currentFailMessage)) {
                		currentFailMessage = m;
                		Log.warn(this, m); 
                	}
    
    catching the case where the same pattern error keeps occuring.
    This might be either of overkill or underkill.
    
    Chris
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---