You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/05 11:12:31 UTC
[GitHub] [lucene-solr] asalamon74 opened a new pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums
asalamon74 opened a new pull request #2309:
URL: https://github.com/apache/lucene-solr/pull/2309
…Checksums
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Right now gradle calculates SHA-1 checksums using an external commons-codec library. We can calculate SHA-1 using Java 8 classes, no need for commons-codec here.
# Solution
Eliminate commons-codec usage in checksum validation.
# Tests
./gradlew validateJarChecksums
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2309:
URL: https://github.com/apache/lucene-solr/pull/2309#issuecomment-774426602
I think it's just much shorter invocation in the end - when you look at the diff you'll see it. I also don't know if the checksum format is required to be supported by the JDK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #2309:
URL: https://github.com/apache/lucene-solr/pull/2309#issuecomment-774283250
I _believe_ this was done with an external dependency because there's an issue with how checksums were handled on Windows, but I don't remember all the details and can't find it now. Maybe @dweiss can remember.
We also do the same thing in `releasing.gradle`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] asalamon74 commented on pull request #2309: SOLR-14301: Remove external commons-codec usage in gradle validateJarChecksums
Posted by GitBox <gi...@apache.org>.
asalamon74 commented on pull request #2309:
URL: https://github.com/apache/lucene-solr/pull/2309#issuecomment-778613952
Yes, the invocation is longer with this patch, on the other hand we avoid using an external library so the .gradle file is shorter.
We only require that SHA-1 is supported by the JDK, which is a requirement for all JDK implementations: https://docs.oracle.com/javase/7/docs/api/java/security/MessageDigest.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org