You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "Aryankb (via GitHub)" <gi...@apache.org> on 2025/03/07 07:46:08 UTC
[PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Aryankb opened a new pull request, #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197
Fixes #173
Fixes:-
- Enabled streaming output generation in` rag_block -> rag_answer`, can be applied to all other output boxes of gradio
- updated gradio to 5.20.0, no breaking changes found.
- exploring more gradio features, will try to update them with future issues.
Modifications:-
used gr.update() in rag_block to generate streaming output.
How to Test:-
Run python3 -m hugegraph_llm.demo.rag_demo.app in CLI
click `Answer question` under `RAG and user functions`.
the output is streaming. (though it is not async. the final output is streaming after collecting all outputs)
[Screencast from 03-07-2025 01:13:46 PM.webm](https://github.com/user-attachments/assets/b4b20744-2b0e-43ac-b8fc-28ba5b1d3e8b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "Aryankb (via GitHub)" <gi...@apache.org>.
Aryankb commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197#issuecomment-2705813195
@imbajin
i tried my best to have async streaming. but due to many different blocking functions, not able to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197#issuecomment-2888449597
> > @imbajin okay, so i just need to list the possible changes (useful features) or need to make changes in gradio?
> > Also, After which PR merge, async streaming was working? Because I fetched the main branch yesterday, it was not working, so i made these changes. And now it is streaming but not async (after my changes)
>
> refer #190 (Added async func calls to the entire path, but some places have **TODO**)
>
> After introducing the async workflow framework, we should make all current operator/step calls async. Currently, there are many synchronous places, so it is very troublesome to change them
Close this PR due to the function already supported & we move to `uv` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin closed pull request #197: fix(llm) : Streaming output generation and update gradio to latest version
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197#issuecomment-2705905715
> @imbajin okay, so i just need to list the possible changes (useful features) or need to make changes in gradio?
>
> Also, After which PR merge, async streaming was working? Because I fetched the main branch yesterday, it was not working, so i made these changes. And now it is streaming but not async (after my changes)
refer https://github.com/apache/incubator-hugegraph-ai/pull/190 (Added async func calls to the entire path, but some places have **TODO**)
After introducing the async workflow framework, we should make all current operator/step calls async. Currently, there are many synchronous places, so it is very troublesome to change them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197#issuecomment-2705848780
> i tried my best to have async streaming. but due to many different blocking functions, not able to do it.
@Aryankb Thank you for your attempt, we already implement a partially less elegant asynchronous streaming output by modifying the previous version.
We can keep this implementation first and let the current PR only upgrade the gradio version. If possible, a simple list of the useful features of 4.x -> 5.x for us is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(llm) : Streaming output generation and update gradio to latest version [incubator-hugegraph-ai]
Posted by "Aryankb (via GitHub)" <gi...@apache.org>.
Aryankb commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/197#issuecomment-2705867935
@imbajin okay, so i just need to list the possible changes or need to make changes in gradio?
Also,
After which PR merge, async streaming was working? Because I fetched the main branch yesterday, it was not working, so i made these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org