You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@teaclave.apache.org by Chines Wang <no...@github.com.INVALID> on 2023/03/31 15:26:07 UTC

[apache/incubator-teaclave-sgx-sdk] midified atomic::ordering about FIRST_PANIC (PR #427)

https://github.com/wang384670111/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panicking.rs#L288
I think the use of ordering here is irregular, FIRST_PANIC is used here for Signals in a multi-threaded environment, not to synchronize access to other shared variables. Although Ordering::SeqCst ensures the correctness of the program, it affects the performance of the program. Therefore, just Ordering::Relaxed needs to be used here to ensure the correctness of the program.
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave-sgx-sdk/pull/427

-- Commit Summary --

  * midified atomic::ordering about FIRST_PANIC

-- File Changes --

    M sgx_tstd/src/panicking.rs (2)

-- Patch Links --

https://github.com/apache/incubator-teaclave-sgx-sdk/pull/427.patch
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/427.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/427
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/incubator-teaclave-sgx-sdk/pull/427@github.com&gt;

Re: [apache/incubator-teaclave-sgx-sdk] midified atomic::ordering about FIRST_PANIC (PR #427)

Posted by volcano <no...@github.com.INVALID>.

@wang384670111 Thanks for reporting this issue.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/427#issuecomment-1498917264
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>