You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Balavva-Mirji (via GitHub)" <gi...@apache.org> on 2023/03/27 10:02:26 UTC
[GitHub] [camel] Balavva-Mirji opened a new pull request, #9652: Added power supported zookeeper image
Balavva-Mirji opened a new pull request, #9652:
URL: https://github.com/apache/camel/pull/9652
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #9652: Added power supported zookeeper image
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #9652:
URL: https://github.com/apache/camel/pull/9652#discussion_r1149149167
##########
test-infra/camel-test-infra-zookeeper/src/test/java/org/apache/camel/test/infra/zookeeper/services/ZooKeeperContainer.java:
##########
@@ -23,7 +23,12 @@
import org.testcontainers.containers.wait.strategy.Wait;
public class ZooKeeperContainer extends GenericContainer {
- public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ if (arch == ppc64le) {
+ public static final String CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv"
+ } else {
+ public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ }
+
Review Comment:
I'm not sure that it can compile, maybe you meant:
`public static final String CONTAINER_IMAGE = arch == ppc64le ? "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv" : "zookeeper:3.5";`
or
```
public static final String CONTAINER_IMAGE;
static {
if (arch == ppc64le) {
CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv";
} else {
CONTAINER_IMAGE = "zookeeper:3.5";
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Balavva-Mirji commented on pull request #9652: Added power supported zookeeper image
Posted by "Balavva-Mirji (via GitHub)" <gi...@apache.org>.
Balavva-Mirji commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1497258918
@orpiske - Somehow above power supported image is not working as expected on power arch for time being, currently checking on that. Once that issue is resolved will modify the PR.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Balavva-Mirji commented on pull request #9652: Added power supported zookeeper image
Posted by "Balavva-Mirji (via GitHub)" <gi...@apache.org>.
Balavva-Mirji commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1485059480
@orpiske @essobedo I have created a new issue regarding this PR.
Please find the issue link: https://issues.apache.org/jira/browse/CAMEL-19208
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Balavva-Mirji commented on a diff in pull request #9652: Added power supported zookeeper image
Posted by "Balavva-Mirji (via GitHub)" <gi...@apache.org>.
Balavva-Mirji commented on code in PR #9652:
URL: https://github.com/apache/camel/pull/9652#discussion_r1149167485
##########
test-infra/camel-test-infra-zookeeper/src/test/java/org/apache/camel/test/infra/zookeeper/services/ZooKeeperContainer.java:
##########
@@ -23,7 +23,12 @@
import org.testcontainers.containers.wait.strategy.Wait;
public class ZooKeeperContainer extends GenericContainer {
- public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ if (arch == ppc64le) {
+ public static final String CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv"
+ } else {
+ public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ }
+
Review Comment:
@essobedo locally all the above 3 changes are working.
`public static final String CONTAINER_IMAGE = arch == ppc64le ? "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv" : "zookeeper:3.5";`
Let me use above way to use the zoo-keeper image, as it will optimize the code. Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9652: Added power supported zookeeper image
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1485073717
> @orpiske @essobedo I have created a new JIRA issue regarding this PR. Please find the issue link: https://issues.apache.org/jira/browse/CAMEL-19208 Thanks.
Thanks. I used the ticket comments to explain how to do what you want. If that works, please modify the code accordingly and send a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #9652: Added power supported zookeeper image
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #9652:
URL: https://github.com/apache/camel/pull/9652#discussion_r1149221884
##########
test-infra/camel-test-infra-zookeeper/src/test/java/org/apache/camel/test/infra/zookeeper/services/ZooKeeperContainer.java:
##########
@@ -23,7 +23,12 @@
import org.testcontainers.containers.wait.strategy.Wait;
public class ZooKeeperContainer extends GenericContainer {
- public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ if (arch == ppc64le) {
+ public static final String CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv"
+ } else {
+ public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ }
+
Review Comment:
I'm afraid that it cannot even work this way because `arch` and `ppc64le` are both unknown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9652: Added power supported zookeeper image
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1490177684
Is this still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Balavva-Mirji closed pull request #9652: Added power supported zookeeper image
Posted by "Balavva-Mirji (via GitHub)" <gi...@apache.org>.
Balavva-Mirji closed pull request #9652: Added power supported zookeeper image
URL: https://github.com/apache/camel/pull/9652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Balavva-Mirji commented on pull request #9652: Added power supported zookeeper image
Posted by "Balavva-Mirji (via GitHub)" <gi...@apache.org>.
Balavva-Mirji commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1484870583
Locally I have validated above change on ppc64le arch & it's working as expected.
Here attaching the snippet of logs for the same:
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0:verify (integration-test) @ camel-zookeeper ---
[INFO]
[INFO] --- maven-install-plugin:3.1.0:install (default-install) @ camel-zookeeper ---
[INFO] Installing /camel/camel/components/camel-zookeeper/target/camel-zookeeper-4.0.0-SNAPSHOT.pom to /root/.m2/repository/org/apache/camel/camel-zookeeper/4.0.0-SNAPSHOT/camel-zookeeper-4.0.0-SNAPSHOT.pom
[INFO] Installing /camel/camel/components/camel-zookeeper/target/camel-zookeeper-4.0.0-SNAPSHOT.jar to /root/.m2/repository/org/apache/camel/camel-zookeeper/4.0.0-SNAPSHOT/camel-zookeeper-4.0.0-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:02 min
[INFO] Finished at: 2023-03-27T05:03:31-05:00
[INFO] ------------------------------------------------------------------------
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #9652: Added power supported zookeeper image
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #9652:
URL: https://github.com/apache/camel/pull/9652#discussion_r1149149167
##########
test-infra/camel-test-infra-zookeeper/src/test/java/org/apache/camel/test/infra/zookeeper/services/ZooKeeperContainer.java:
##########
@@ -23,7 +23,12 @@
import org.testcontainers.containers.wait.strategy.Wait;
public class ZooKeeperContainer extends GenericContainer {
- public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ if (arch == ppc64le) {
+ public static final String CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv"
+ } else {
+ public static final String CONTAINER_IMAGE = "zookeeper:3.5";
+ }
+
Review Comment:
I'm not sure that it can compile, maybe you meant:
`public static final String CONTAINER_IMAGE = arch == ppc64le ? "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv" : "zookeeper:3.5";`
or
```
public static final String CONTAINER_IMAGE;
if (arch == ppc64le) {
CONTAINER_IMAGE = "icr.io/ppc64le-oss/zookeeper-ppc64le:v3.8.0-bv"
} else {
CONTAINER_IMAGE = "zookeeper:3.5";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9652: Added power supported zookeeper image
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9652:
URL: https://github.com/apache/camel/pull/9652#issuecomment-1485039023
Maybe you could create a ticket first in JIRA https://issues.apache.org/jira/browse/CAMEL to describe clearly the problem you would like to solve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org