You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Hervé BOUTEMY <he...@free.fr> on 2012/06/25 00:20:59 UTC
releasing plugin-tools 3.1
Thanks to good reports, we were able to fix a handful of problems found in 3.0.
If nobody complains, I intend to do the next release by the end of the week.
Regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Tony Chemit <ch...@codelutin.com>.
On Tue, 26 Jun 2012 09:03:36 +0200
Olivier Lamy <ol...@apache.org> wrote:
> Just applied.
> Thanks !
And now could we start a vote ?
I'd like to release license-m-p but there is a blocker issue (MPLUGIN-213) that can not permit me to release the project.
thanks,
tony
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Olivier Lamy <ol...@apache.org>.
Just applied.
Thanks !
--
Olivier
2012/6/26 Tony Chemit <ch...@codelutin.com>:
> On Mon, 25 Jun 2012 23:36:51 +0200
> "Robert Scholte" <rf...@apache.org> wrote:
>
>> Hi,
>>
>> I've discovered the cause of the HelpMojo plugin, Olivier has fixed it
>> (thanks!).
>> I have verified all the issues I've mentioned before and can confirm these
>> have been fixed by Hervé and work as expcted (thanks too!).
>> But I found one funny bug: MPLUGIN-217. Not a showstopper, but IMHO should
>> be fixed as well.
>
> I just attach a fix for this.
>
> hope somebody will apply it before release 3.1
>
> tony.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Tony Chemit <ch...@codelutin.com>.
On Mon, 25 Jun 2012 23:36:51 +0200
"Robert Scholte" <rf...@apache.org> wrote:
> Hi,
>
> I've discovered the cause of the HelpMojo plugin, Olivier has fixed it
> (thanks!).
> I have verified all the issues I've mentioned before and can confirm these
> have been fixed by Hervé and work as expcted (thanks too!).
> But I found one funny bug: MPLUGIN-217. Not a showstopper, but IMHO should
> be fixed as well.
I just attach a fix for this.
hope somebody will apply it before release 3.1
tony.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Robert Scholte <rf...@apache.org>.
Hi,
I've discovered the cause of the HelpMojo plugin, Olivier has fixed it
(thanks!).
I have verified all the issues I've mentioned before and can confirm these
have been fixed by Hervé and work as expcted (thanks too!).
But I found one funny bug: MPLUGIN-217. Not a showstopper, but IMHO should
be fixed as well.
Looks like it is possible to start the vote soon.
-Robert
Op Mon, 25 Jun 2012 19:12:15 +0200 schreef Tony Chemit
<ch...@codelutin.com>:
> On Mon, 25 Jun 2012 00:20:59 +0200
> Hervé BOUTEMY <he...@free.fr> wrote:
>
>> Thanks to good reports, we were able to fix a handful of problems found
>> in 3.0.
>> If nobody complains, I intend to do the next release by the end of the
>> week.
>>
> +1 I really wants to use the java annotations for license-m-p and
> MPLUGIN-213 was a blocker for MLICENSE-41.
>
> Good works guys ;)
>
> tony.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Tony Chemit <ch...@codelutin.com>.
On Mon, 25 Jun 2012 00:20:59 +0200
Hervé BOUTEMY <he...@free.fr> wrote:
> Thanks to good reports, we were able to fix a handful of problems found in 3.0.
> If nobody complains, I intend to do the next release by the end of the week.
>
+1 I really wants to use the java annotations for license-m-p and MPLUGIN-213 was a blocker for MLICENSE-41.
Good works guys ;)
tony.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Olivier Lamy <ol...@apache.org>.
Yup but normaly the class is rename and remove later.
Because at this stage with annos we don't know the base package of the mojo.
--
Olivier
Le 25 juin 2012 18:56, "Robert Scholte" <rf...@apache.org> a écrit :
> I think I see the problem:
>
> HelpGeneratorPlugin:
> return new PluginHelpGenerator().**setHelpPackageName( helpPackageName
> ).setVelocityComponent( this.velocity );
>
> PluginHelpGenerator:
> properties.put( "helpPackageName", helpPackageName == null ? "" :
> helpPackageName );
>
> If the value of @Parameter is "" by default instead of null as it used to
> be, we have a problem...
>
> -Robert
>
>
> Op Mon, 25 Jun 2012 18:54:00 +0200 schreef Olivier Lamy <olamy@apache.org
> >:
>
> Thanks Hervé !
>>
>> @Robert this looks weird. Do you have this issue with the release plugin ?
>>
>> 2012/6/25 Robert Scholte <rf...@apache.org>:
>>
>>> Great idea!
>>> I still have an issue with the HelpMojo class, which ends up under both
>>> target/generated-sources/**plugin and target/classes with the default
>>> package
>>> in the source.
>>> Might be a Win-thing, I'll have a look at it.
>>>
>>> -Robert
>>>
>>> Op Mon, 25 Jun 2012 00:20:59 +0200 schreef Hervé BOUTEMY
>>> <he...@free.fr>:
>>>
>>>
>>> Thanks to good reports, we were able to fix a handful of problems found
>>>> in
>>>> 3.0.
>>>> If nobody complains, I intend to do the next release by the end of the
>>>> week.
>>>>
>>>> Regards,
>>>>
>>>> Hervé
>>>>
>>>> ------------------------------**------------------------------**
>>>> ---------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>>
>>> ------------------------------**------------------------------**
>>> ---------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.**org<de...@maven.apache.org>
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: releasing plugin-tools 3.1
Posted by Robert Scholte <rf...@apache.org>.
I think I see the problem:
HelpGeneratorPlugin:
return new PluginHelpGenerator().setHelpPackageName( helpPackageName
).setVelocityComponent( this.velocity );
PluginHelpGenerator:
properties.put( "helpPackageName", helpPackageName == null ? "" :
helpPackageName );
If the value of @Parameter is "" by default instead of null as it used to
be, we have a problem...
-Robert
Op Mon, 25 Jun 2012 18:54:00 +0200 schreef Olivier Lamy <ol...@apache.org>:
> Thanks Hervé !
>
> @Robert this looks weird. Do you have this issue with the release plugin
> ?
>
> 2012/6/25 Robert Scholte <rf...@apache.org>:
>> Great idea!
>> I still have an issue with the HelpMojo class, which ends up under both
>> target/generated-sources/plugin and target/classes with the default
>> package
>> in the source.
>> Might be a Win-thing, I'll have a look at it.
>>
>> -Robert
>>
>> Op Mon, 25 Jun 2012 00:20:59 +0200 schreef Hervé BOUTEMY
>> <he...@free.fr>:
>>
>>
>>> Thanks to good reports, we were able to fix a handful of problems
>>> found in
>>> 3.0.
>>> If nobody complains, I intend to do the next release by the end of the
>>> week.
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Olivier Lamy <ol...@apache.org>.
Thanks Hervé !
@Robert this looks weird. Do you have this issue with the release plugin ?
2012/6/25 Robert Scholte <rf...@apache.org>:
> Great idea!
> I still have an issue with the HelpMojo class, which ends up under both
> target/generated-sources/plugin and target/classes with the default package
> in the source.
> Might be a Win-thing, I'll have a look at it.
>
> -Robert
>
> Op Mon, 25 Jun 2012 00:20:59 +0200 schreef Hervé BOUTEMY
> <he...@free.fr>:
>
>
>> Thanks to good reports, we were able to fix a handful of problems found in
>> 3.0.
>> If nobody complains, I intend to do the next release by the end of the
>> week.
>>
>> Regards,
>>
>> Hervé
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: releasing plugin-tools 3.1
Posted by Robert Scholte <rf...@apache.org>.
Great idea!
I still have an issue with the HelpMojo class, which ends up under both
target/generated-sources/plugin and target/classes with the default
package in the source.
Might be a Win-thing, I'll have a look at it.
-Robert
Op Mon, 25 Jun 2012 00:20:59 +0200 schreef Hervé BOUTEMY
<he...@free.fr>:
> Thanks to good reports, we were able to fix a handful of problems found
> in 3.0.
> If nobody complains, I intend to do the next release by the end of the
> week.
>
> Regards,
>
> Hervé
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org