You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cn...@apache.org on 2016/10/06 18:03:39 UTC
[3/3] hadoop git commit: HADOOP-13323. Downgrade stack trace on FS
load from Warn to debug. Contributed by Steve Loughran.
HADOOP-13323. Downgrade stack trace on FS load from Warn to debug. Contributed by Steve Loughran.
(cherry picked from commit 2d46c3f6b7d55b6a2f124d07fe26d37359615df4)
(cherry picked from commit ecccb114ae1b09526d11385df7085b6dd3376e2d)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/b9ce40e1
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/b9ce40e1
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/b9ce40e1
Branch: refs/heads/branch-2.8
Commit: b9ce40e12cb15022c7a6cbb2e35e3625e70004da
Parents: 319b101
Author: Chris Nauroth <cn...@apache.org>
Authored: Thu Oct 6 10:57:01 2016 -0700
Committer: Chris Nauroth <cn...@apache.org>
Committed: Thu Oct 6 10:57:15 2016 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/fs/FileSystem.java | 10 +++++++++-
.../apache/hadoop/fs/TestFileSystemInitialization.java | 12 ++++--------
2 files changed, 13 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/b9ce40e1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
index 054f86e..9825181 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
@@ -2764,7 +2764,15 @@ public abstract class FileSystem extends Configured implements Closeable {
ClassUtil.findContainingJar(fs.getClass()), e);
}
} catch (ServiceConfigurationError ee) {
- LOG.warn("Cannot load filesystem", ee);
+ LOG.warn("Cannot load filesystem: " + ee);
+ Throwable cause = ee.getCause();
+ // print all the nested exception messages
+ while (cause != null) {
+ LOG.warn(cause.toString());
+ cause = cause.getCause();
+ }
+ // and at debug: the full stack
+ LOG.debug("Stack Trace", ee);
}
}
FILE_SYSTEMS_LOADED = true;
http://git-wip-us.apache.org/repos/asf/hadoop/blob/b9ce40e1/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java
index 18e8b01..4d627a5 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java
@@ -47,16 +47,12 @@ public class TestFileSystemInitialization {
@Test
public void testMissingLibraries() {
- boolean catched = false;
try {
Configuration conf = new Configuration();
- FileSystem.getFileSystemClass("s3a", conf);
- } catch (Exception e) {
- catched = true;
- } catch (ServiceConfigurationError e) {
- // S3A shouldn't find AWS SDK and fail
- catched = true;
+ Class<? extends FileSystem> fs = FileSystem.getFileSystemClass("s3a",
+ conf);
+ fail("Expected an exception, got a filesystem: " + fs);
+ } catch (Exception | ServiceConfigurationError expected) {
}
- assertTrue(catched);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org