You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/08/23 20:57:52 UTC
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14130
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Remove redundant table name population in Kudu integration
This patch removes the hack to populate table name if empty in Kudu
integration. Since with the current Kudu version, the storage handler
now supports 'kudu.table_name' property and this table name should not
be empty.
Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
1 file changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/14130/1
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:47:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Patch Set 1: Code-Review+2
I assume CDH_BUILD_NUMBER doesn't need to be bumped?
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 23:30:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4846/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 16:37:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> I assume CDH_BUILD_NUMBER doesn't need to be bumped?
No, I don't think so.
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 16:37:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 21:39:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove redundant table name population in Kudu integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14130 )
Change subject: Remove redundant table name population in Kudu integration
......................................................................
Remove redundant table name population in Kudu integration
This patch removes the hack to populate table name if empty in Kudu
integration. Since with the current Kudu version, the storage handler
now supports 'kudu.table_name' property and this table name should not
be empty.
Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Reviewed-on: http://gerrit.cloudera.org:8080/14130
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
1 file changed, 0 insertions(+), 25 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa88ae5f0597ef203b60adcc972d06f8f4a418b7
Gerrit-Change-Number: 14130
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>