[jira] [Commented] (SLING-4372) The use of finalize in ResourceResolver leads to performance issues

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298407#comment-14298407 ] 

Felix Meschberger commented on SLING-4372:
------------------------------------------

I like this idea and would welcome a patch.

Background: When creating the {{finalize()}} we were aware of the problems and we only created it after carefull consideration and weighing and considered the drawbacks you mentioned less problematic than not having closed ResourceResolvers lingering around.

> The use of finalize in ResourceResolver leads to performance issues
> -------------------------------------------------------------------
>
>                 Key: SLING-4372
>                 URL: https://issues.apache.org/jira/browse/SLING-4372
>             Project: Sling
>          Issue Type: Improvement
>    Affects Versions: Resource Resolver 1.1.12
>            Reporter: Konrad Windszus
>
> Currently there is a finalizer implemented for the ResourceResolverImpl (http://svn.apache.org/repos/asf/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java).
> This defers garbage collection. For a more detailed analysis and also some metrics around that have a look at https://issues.apache.org/jira/browse/JCR-2768.
> A similar approach like in the patch attached to JCR-2768 should be implemented for the ResourceResolverImpl.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)