You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 22:04:32 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #8829: Fix KubernetesPodOperator pod name length validation

kaxil commented on a change in pull request #8829:
URL: https://github.com/apache/airflow/pull/8829#discussion_r425456845



##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -322,5 +322,5 @@ def _set_resources(resources):
     def _set_name(self, name):
         if self.pod_template_file or self.full_pod_spec:
             return None
-        validate_key(name, max_length=63)
+        validate_key(name, max_length=220)

Review comment:
       Can we add tests too, please?
   
   @dimberman Can you take a look please at this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org