You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/10/05 21:16:40 UTC
[PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
kou opened a new pull request, #38056:
URL: https://github.com/apache/arrow/pull/38056
### Rationale for this change
We don't need `Threads::Threads` with `ARROW_ENABLE_THREADING=OFF`.
### What changes are included in this PR?
* Don't run `find_package(Threads)` with `ARROW_ENABLE_THREADING=OFF`
* Report an error for building jemalloc/mimalloc/gRPC/aws-sdk-cpp/google-cloud-cpp/OpenTelemetry with `ARROW_ENABLE_THREADING=OFF`
* Use `target_link_libraries(INTERFACE)` instead of `set_target_properties(INTERFACE_LINK_LIBRARIES)`
* This is not required. It's just for modernizing CMake codes.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749818534
Revision: f6d3485385d026943fb807322f7b66f4a4ca60a0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3d0990ee3d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3d0990ee3d)
|Task|Status|
|----|------|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6425806007/job/17449015383)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1757774279
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ae5b30e74b1f02166591feb6f99c85e3c6d5fd87.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17605839697) has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38056:
URL: https://github.com/apache/arrow/pull/38056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749656846
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749842511
Revision: ed4f784ff5ee974f1bf4b4118baaf7fe129eb10c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-97ba1381df](https://github.com/ursacomputing/crossbow/branches/all?query=actions-97ba1381df)
|Task|Status|
|----|------|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6426101670/job/17449791187)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749816869
@github-actions crossbow submit test-ubuntu-22.04-cpp-no-threading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1753864301
Revision: 6234c970e0ad6374e798f6cea1d89f2cbc7dd7d6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b5d5b2b02e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b5d5b2b02e)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661566/job/17541806977)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661572/job/17541807001)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661614/job/17541806967)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/17541808331)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661723/job/17541807731)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661618/job/17541807194)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661710/job/17541807532)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661635/job/17541807435)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661758/job/17541807708)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661791/job/17541807928)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661842/job/17541807946)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661787/job/17541807840)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661878/job/17541807768)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661911/job/17541808246)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6461661989/job/17541808537)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749840814
@github-actions crossbow submit test-ubuntu-22.04-cpp-no-threading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749832260
@github-actions crossbow submit test-ubuntu-22.04-cpp-no-threading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749657215
:warning: GitHub issue #38055 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1753857957
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749660530
Revision: f412884e09d5d4152fa9360e2dbb0bc45a128c10
Submitted crossbow builds: [ursacomputing/crossbow @ actions-db981b8461](https://github.com/ursacomputing/crossbow/branches/all?query=actions-db981b8461)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424585742/job/17445510180)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/6424579564/job/17445493132)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424581333/job/17445497980)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/17445501716)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424582463/job/17445501303)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6424583664/job/17445505352)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/6424585217/job/17445508877)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424582810/job/17445502623)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424581689/job/17445499192)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/6424583080/job/17445503486)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/6424581028/job/17445496904)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/6424586656/job/17445512433)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6424580697/job/17445495640)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/6424584194/job/17445507022)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6424580314/job/17445494317)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1749833726
Revision: dde40b91e4413964ec5421052fecc853331d3d87
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dd159c2615](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dd159c2615)
|Task|Status|
|----|------|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/6425990350/job/17449510965)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38055: [C++] Don't find/use Threads::Threads with ARROW_ENABLE_THREADING=OFF [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38056:
URL: https://github.com/apache/arrow/pull/38056#issuecomment-1754222994
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org